Lock video rotation to landscape but display in portrait

[linktohack]

Hello, please let me know if this is the right place to ask.

I'm having problem with screen rotation of the device, basically the screen orientation (portrait, 1080x1920) & input capture (click) are correct, but the video stream of the screen are not (c.f. screenshot 1 & output 1)

❯ ninja -Cx && ./run x --lock-video-orientation 0                                                                                                                                           scrcpy/git/dev 
ninja: Entering directory `x'
[0/1] Generating scrcpy-server with a custom command.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 739ms
26 actionable tasks: 1 executed, 25 up-to-date
2020-03-03 09:57:38.751 scrcpy[72447:1637298] INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
x/server/scrcpy-server: 1 file pushed. 1.8 MB/s (26886 bytes in 0.014s)
2020-03-03 09:57:39.175 scrcpy[72447:1637298] INFO: Initial texture: 1080x1920

When I try to lock screen to rotate 90 degree, it works perfectly, but then everything is rotated (c.f. screenshot2 and output 2)

❯ ninja -Cx && ./run x --lock-video-orientation 1                                                                                                                                           scrcpy/git/dev 
ninja: Entering directory `x'
[0/1] Generating scrcpy-server with a custom command.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 758ms
26 actionable tasks: 1 executed, 25 up-to-date
2020-03-03 10:03:17.570 scrcpy[72684:1643900] INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
x/server/scrcpy-server: 1 file pushed. 1.8 MB/s (26886 bytes in 0.015s)
2020-03-03 10:03:17.999 scrcpy[72684:1643900] INFO: Initial texture: 1080x1920
2020-03-03 10:03:18.126 scrcpy[72684:1643900] INFO: New texture: 1920x1080

My question is "is there a way to rotate the stream again 90 degree so I can work with the app normally without having my neck rotated." I don't mind to hard code a walkaround for this specific case, but still don't know where I can modify the code, client or server etc.

Regards,

Screenshots
https://imgur.com/a/VC2kvEg

[rom1v]

ninja -Cx && ./run x --lock-video-orientation 0

On which version exactly (which commit SHA1)?

[rom1v]

If you record, does the problem also occurs on the recorded video?

./run x && --lock-video-orientation 1 --record file.mkv

[linktohack]

Thank you for your quick reply, @rom1v
I'm on dev with the latest commit from d3281f4

[linktohack]

@rom1v please note that is is not a bug reporting but a question. scrcpy is working as expected and I guess the problem comes from the device.

The video shows exactly what I see on the screen, e.g.

ninja -Cx && ./run x --lock-video-orientation 0 --record file.mkv

gives a portrait screen with video rotated on bottom and black on top

ninja -Cx && ./run x --lock-video-orientation 1 --record file.mkv

gives a landscape screen with everything rotated, include input capture (so it works correctly, but rotated CCW)

[rom1v]

please note that is is not a bug reporting but a question.

This is a bug (this is not the expected behavior).

I managed to reproduce the problem on my test device:

• rotate the device so that it is in landscape mode
• rotate 90° so that it is upside down (the screen content remains in landscape mode)
• start scrcpy --lock-video-orientation 1

(cc @Stamoulohta)

[rom1v]

I managed to reproduce the problem on my test device

Oh no, it was with an additional local commit of mine.

[linktohack]

Actually I think you're right. It's a bug (but mostly due to an unexpected, custom device like mine): without any video lock rotation, the stream is rotated and displayed at the bottom. I'm unable to request screen rotation as well (Cmd + R)

I'm back to master and try to debug the problem.

Basically up to here https://github.com/Genymobile/scrcpy/blob/master/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java#L70 everything seems okay (contentRect, videoRect are all in portrait) but the encoded stream are rotated (and cropped)

I tried to set

        format.setInteger("rotation-degrees", 90);

but to no avail. I'm thinking of adding a MediaMuxer with setOrientationHint with to the pipeline but your advice are appreciated.

Thank you,

[rom1v]

Could you test on your device, on dev, with the following logs, please:

diff --git a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
index 3e9772e..1f89380 100644
--- a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
+++ b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
@@ -73,6 +73,8 @@ public class ScreenEncoder implements Device.RotationListener {
                 configure(codec, format);
                 Surface surface = codec.createInputSurface();
                 setDisplaySurface(display, surface, videoRotation, contentRect, videoRect);
+                Ln.i("videoRotation = " + videoRotation);
+                Ln.i("videoRect = " + videoRect);
                 codec.start();
                 try {
                     alive = encode(codec, fd);

[linktohack]

That was the first thing i tried, both give 1080x1920. I can setup an adb over internet if you want to have a look (of course if only you are curious, because I think the problem comes from the device)

[rom1v]

Do you have these values:

INFO: Initial texture: 1080x1920
[server] INFO: videoRotation = 3
[server] INFO: videoRect = Rect(0, 0 - 1080, 1920)
INFO: New texture: 1920x1080

?

[linktohack]

No, videoRotation = 0

[rom1v]

When you launch with --lock-video-orientation 1?

[rom1v]

diff --git a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
index 3e9772e..ceeb8aa 100644
--- a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
+++ b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java
@@ -73,6 +73,9 @@ public class ScreenEncoder implements Device.RotationListener {
                 configure(codec, format);
                 Surface surface = codec.createInputSurface();
                 setDisplaySurface(display, surface, videoRotation, contentRect, videoRect);
+                Ln.i("deviceRotation = " + screenInfo.getRotation());
+                Ln.i("videoRotation = " + videoRotation);
+                Ln.i("videoRect = " + videoRect);
                 codec.start();
                 try {
                     alive = encode(codec, fd);