Skip to content

[Enhancement]Make logger unchecked sendable#64

Merged
ipavlidakis merged 1 commit into
developfrom
iliaspavlidakis/make-logger-unchecked-sendable
Jul 13, 2026
Merged

[Enhancement]Make logger unchecked sendable#64
ipavlidakis merged 1 commit into
developfrom
iliaspavlidakis/make-logger-unchecked-sendable

Conversation

@ipavlidakis

Copy link
Copy Markdown
Contributor

🔗 Issue Links

🎯 Goal

Allow Logger to be safely captured by @Sendable closures and restore the concurrency contract previously provided by StreamVideo’s logger.

📝 Summary

  • Add @unchecked Sendable conformance to Logger.
  • Add a Swift Testing concurrency regression test.
  • Verify concurrent logging processes every message and preserves caller thread metadata.

🛠 Implementation

Logger now declares @unchecked Sendable because it is a reference type that supports concurrent logging through its serialized delivery queue.

The regression test uses a task group to log 200 messages concurrently and verifies that every message is processed.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@ipavlidakis ipavlidakis self-assigned this Jul 13, 2026
@ipavlidakis
ipavlidakis requested a review from a team as a code owner July 13, 2026 14:23
@ipavlidakis ipavlidakis added the ✅ Feature An issue or PR related to a feature label Jul 13, 2026
@sonarqubecloud

Copy link
Copy Markdown

@martinmitrevski martinmitrevski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ipavlidakis
ipavlidakis merged commit 124f0aa into develop Jul 13, 2026
8 checks passed
@ipavlidakis
ipavlidakis deleted the iliaspavlidakis/make-logger-unchecked-sendable branch July 13, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ Feature An issue or PR related to a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants