fix(rust-debian): default both jobs to bash shell#72
Merged
Conversation
The dpkg-buildpackage job's 'Confirm the .deb was produced' step uses bash arrays and 'shopt -s nullglob'; with the container's default dash shell it failed with 'shopt: not found' (exit 127). Setting defaults.run.shell: bash on both jobs makes every run step use bash, covering this and any future bashism (the offline build step's POSIX fix from v1.6.1 still works). Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
added a commit
that referenced
this pull request
Jun 29, 2026
## What The `rust-debian` reusable workflow's offline build step split the extra cargo args with `set -- $OFFLINE_ARGS` — an unquoted expansion. shellcheck flags that as **SC2086**, and since the Actionlint job runs shellcheck over every `run:` block, the whole CI went red on each push to main and on unrelated PRs. ## Fix Both jobs already default to `shell: bash` (from #72), so I read the args into a bash array and expand it quoted: ```sh read -ra offline_args <<< "$OFFLINE_ARGS" cargo build --release --locked --offline "${offline_args[@]}" ``` Same intentional word-splitting, no accidental globbing, and shellcheck/Actionlint pass. ## Compatibility No input contract change — `offline-cargo-args`/`OFFLINE_ARGS` are untouched, so callers need no changes. The only consumer (Glyndor/podup) pins an older commit and passes plain feature flags, which split identically. The default image `debian:trixie` ships bash, so the herestring is safe. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to v1.6.1. The
dpkg-buildpackagejob's "Confirm the .deb was produced" step uses bash arrays (debs=( ... )) andshopt -s nullglob, which fail under the container's default dash shell (shopt: not found, exit 127). Rather than POSIX-ify each step, this setsdefaults.run.shell: bashon both jobs so every run step uses bash — fixing this and any future bashism in one place.