fix(rust-debian): split offline cargo args without tripping SC2086#74
Merged
Conversation
The offline build step used `set -- $OFFLINE_ARGS` with an unquoted expansion, which shellcheck flags as SC2086 and fails the Actionlint gate. Both jobs already default to bash, so read the args into a bash array and expand it quoted instead: same word-splitting, no globbing, and the linter passes. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
rust-debianreusable workflow's offline build step split the extra cargo args withset -- $OFFLINE_ARGS— an unquoted expansion. shellcheck flags that as SC2086, and since the Actionlint job runs shellcheck over everyrun:block, the whole CI went red on each push to main and on unrelated PRs.Fix
Both jobs already default to
shell: bash(from #72), so I read the args into a bash array and expand it quoted:Same intentional word-splitting, no accidental globbing, and shellcheck/Actionlint pass.
Compatibility
No input contract change —
offline-cargo-args/OFFLINE_ARGSare untouched, so callers need no changes. The only consumer (Glyndor/podup) pins an older commit and passes plain feature flags, which split identically. The default imagedebian:trixieships bash, so the herestring is safe.