Sync main sept 17 feature branch resource identity #15399
Conversation
…oogleCloudPlatform#14377) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: James Alseth <jalseth@google.com> Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com> Signed-off-by: Misha Efimov <mef@google.com> Signed-off-by: David Xia <david@davidxia.com> Signed-off-by: pcrao <pcrao@google.com> Signed-off-by: Eric Bode <eric.bode@foundries.io> Co-authored-by: Nick Elliot <nickelliot@google.com> Co-authored-by: Cameron Thornton <camthornton@google.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: tulika-aakriti <aakrititulika@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: anthonyrtong <anthonytong99@gmail.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: NA2047 <12290725+NA2047@users.noreply.github.com> Co-authored-by: Chris Hawk <hawk@google.com> Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: Ramon Vermeulen <ramonvermeulen98@gmail.com> Co-authored-by: Sam Levenick <slevenick@google.com> Co-authored-by: Shrishty Chandra <3104562+shrishty@users.noreply.github.com> Co-authored-by: Shrishty Chandra <shrishty@google.com> Co-authored-by: Sharan Teja M <sharantej957@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: James Alseth <james@jalseth.me> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: stevenyang72 <congruiy@google.com> Co-authored-by: oferhandel-google <oferhandel@google.com> Co-authored-by: Jatin Miglani <migjatin@google.com> Co-authored-by: translucens <skwmr@google.com> Co-authored-by: Sing <sing@paddingleft.com> Co-authored-by: paridhishah18 <166548459+paridhishah18@users.noreply.github.com> Co-authored-by: Ronson Xaviour <50081163+ronsonx@users.noreply.github.com> Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Cezary Sobczak <57288981+Cezarus27@users.noreply.github.com> Co-authored-by: Betto Cerrillos <32439055+Berro321@users.noreply.github.com> Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com> Co-authored-by: Or Sela <orsela1@gmail.com> Co-authored-by: Samir Ribeiro <42391123+Samir-Cit@users.noreply.github.com> Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com> Co-authored-by: kigesui <kigesui@hotmail.com> Co-authored-by: Meng Yang <mengyang@google.com> Co-authored-by: Ashwin G <ashwin.gururaghavendran@gmail.com> Co-authored-by: Allison Fisher <amfisher@google.com> Co-authored-by: mihhalj <mihhalj@users.noreply.github.com> Co-authored-by: Guy Bidkar <5646214+gbidkar@users.noreply.github.com> Co-authored-by: Dawid212 <dawid.idzior@infogain.com> Co-authored-by: Michael Lopez <mickael.lopez@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: sahil-mahajan-google <sahilmahajan@google.com> Co-authored-by: kautikdk <144651627+kautikdk@users.noreply.github.com> Co-authored-by: harshithpatte-g <harshithpatte@google.com> Co-authored-by: Rohan Chawla <73727454+rohanchawla23@users.noreply.github.com> Co-authored-by: ML <marek.lipert@gmail.com> Co-authored-by: Marek Lipert <lipertmj@google.com> Co-authored-by: James Alseth <jalseth@google.com> Co-authored-by: Madhura Phadnis <madhura.a.phadnis@gmail.com> Co-authored-by: YashTayal04 <47032845+YashTayal04@users.noreply.github.com> Co-authored-by: Misha Efimov <mef@google.com> Co-authored-by: Aiden Grossman <aidengrossman@google.com> Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com> Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com> Co-authored-by: MatthewVu-dev <matthewsvu@google.com> Co-authored-by: Madhu Suraj <madhusuraj@google.com> Co-authored-by: Matheus Guilherme Souza Aleixo <82680416+matheusaleixo-cit@users.noreply.github.com> Co-authored-by: Jun Luo <luojunmoo@gmail.com> Co-authored-by: Raj Anand <88097156+raazanand@users.noreply.github.com> Co-authored-by: Tommy Reddad <tommy.reddad@gmail.com> Co-authored-by: palramanathan <117597159+palramanathan@users.noreply.github.com> Co-authored-by: Michał Wiatrowski <wiatrowskimich@gmail.com> Co-authored-by: rlapin-pl <114071972+rlapin-pl@users.noreply.github.com> Co-authored-by: rlapin-pl <rlapin@google.com> Co-authored-by: tonybayvas <tonybayvas@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: David Xia <david@davidxia.com> Co-authored-by: sachin purohit <sachinpurohit@google.com> Co-authored-by: bcreddy-gcp <123543489+bcreddy-gcp@users.noreply.github.com> Co-authored-by: Jack Weinbender <jack.weinbender@gmail.com> Co-authored-by: Balanagu Harsha Vardhan <balanaguharsha@google.com> Co-authored-by: porky256 <61063240+porky256@users.noreply.github.com> Co-authored-by: Aman Mahendroo <30946991+amanMahendroo@users.noreply.github.com> Co-authored-by: Andrew Browne <81702808+abbrowne126@users.noreply.github.com> Co-authored-by: Ashwin G <ashwingu@google.com> Co-authored-by: Xian-Ji Chen <68801742+XianJiChen@users.noreply.github.com> Co-authored-by: Nithin Daniel <55326622+nithindaniel@users.noreply.github.com> Co-authored-by: Nithin Daniel <nithindaniel@google.com> Co-authored-by: Michał Wiatrowski <wiatrowskim@google.com> Co-authored-by: veraz0818 <vera.zhang0818@gmail.com> Co-authored-by: DavinaRen <davinaw@google.com> Co-authored-by: dishaagarwal03-google <dishaagarwal@google.com> Co-authored-by: Margubur Rahman <150442997+googlyrahman@users.noreply.github.com> Co-authored-by: Nandini Agrawal <agrawalnandini@google.com> Co-authored-by: Ziting <zitingshenbmc@gmail.com> Co-authored-by: Taneli Leppä <taneli@google.com> Co-authored-by: martin-guillen <martinguillen@google.com> Co-authored-by: FilipKubawskiOkta <filip.kubawski@oktawave.com> Co-authored-by: Calvin Liu <calvinliu@google.com> Co-authored-by: Sepehr Javid <32390553+sepehrjavid@users.noreply.github.com> Co-authored-by: Niharika <35183015+niharika-98@users.noreply.github.com> Co-authored-by: Arnav Dham <arnavdham@google.com> Co-authored-by: Daniel Rieske <DanielRieske@users.noreply.github.com> Co-authored-by: Luca Prete <preteluca@gmail.com> Co-authored-by: Luca Prete <lucaprete@google.com> Co-authored-by: echiugoog <edwinchiu+gh@google.com> Co-authored-by: Justin Scofield <47263509+scawful@users.noreply.github.com> Co-authored-by: liaoaohaha <aoli2386@gmail.com> Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Pradeep Rao <84025829+pradeepcrao@users.noreply.github.com> Co-authored-by: Tlaquetzal <rochingoon@gmail.com> Co-authored-by: StealthyCoder <StealthyCoder@users.noreply.github.com> Co-authored-by: animeshnandanwar <animeshnandanwar@gmail.com> Co-authored-by: Nandini Agrawal <agrawalnandini1503@gmail.com> Co-authored-by: Stephane Charite <cstephane@google.com> Co-authored-by: Steven Davidovitz <13248+steved@users.noreply.github.com> Co-authored-by: vmiglani <142545940+vmiglani@users.noreply.github.com> Co-authored-by: xuebaoZ <xuebaozhao@google.com> Co-authored-by: zhihaos <zhihaos@google.com> Co-authored-by: Hoang Pham <phhoang@google.com> Co-authored-by: vbhadoriaB <150216360+vbhadoriaB@users.noreply.github.com> Co-authored-by: Lakshman Swaminathan <lakshman.swaminathan1@gmail.com> Co-authored-by: luckyswaminathan <lswamina@google.com> Co-authored-by: iamkonohamaru <konohamaru@google.com> Co-authored-by: Brad Fisher <brad.fisher25@gmail.com> Co-authored-by: panerorenn9541 <36008213+panerorenn9541@users.noreply.github.com> Co-authored-by: Keith Jordy <6444028+kjordy@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: coder-221 <185867912+coder-221@users.noreply.github.com> Co-authored-by: Naga Bodepudi <nagabodepudi@google.com> Co-authored-by: Yuval Brik <jhamhader@users.noreply.github.com> Co-authored-by: Ron Gal <125445217+ron-gal@users.noreply.github.com>
…form#14442) Co-authored-by: Riley Karson <rileykarson@google.com>
…URE-BRANCH-7.0.0-jul28
…oogle_cloudfunctions2_function` to attribute (GoogleCloudPlatform#14648) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
…ertex_ai_endpoint` as beta isntead of GA (beta) (GoogleCloudPlatform#14665)
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…t registry repository (GoogleCloudPlatform#14795)
…URE-BRANCH-7.0.0-aug12
…oogleCloudPlatform#15041) Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com>
modular-magician
added
the
awaiting-approval
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
modular-magician
removed
the
awaiting-approval
Summary of ChangesHello @BBBmau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a feature branch into the main codebase, bringing substantial updates to the provider's architecture and resource definitions. The core changes revolve around adopting the new Terraform Plugin Framework for resource generation, refining how write-only and identifier properties are managed, and expanding support for new Google Cloud services. Additionally, the update includes numerous adjustments to existing resource configurations, CI/CD pipelines, and testing utilities to enhance stability and maintainability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a very large pull request that includes a wide range of changes, from refactoring write_only fields and migrating to the Terraform Plugin Framework, to adding new resources and enhancing existing ones. The changes appear to be part of a large, coordinated effort and are generally consistent and well-implemented. I have a couple of suggestions to improve code quality by reducing duplication and avoiding potential side effects.
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ -}} | ||
| func flatten{{$.GetPrefix}}{{$.TitlelizeProperty}}(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) (interface{}) { |
There was a problem hiding this comment.
This function modifies the input map v (casted to headers) in-place. This can lead to unexpected side effects, as the original map from which v was passed is also modified. It's safer to create a copy of the map at the beginning of the function and perform modifications on the copy.
| queuedTime, err := time.Parse(tcTimeFormat, build.QueuedDate) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse QueuedDate: %v", err) | ||
| } | ||
| startTime, err := time.Parse(tcTimeFormat, build.StartDate) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse StartDate: %v", err) | ||
| } | ||
| finishTime, err := time.Parse(tcTimeFormat, build.FinishDate) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse FinishDate: %v", err) | ||
| } |
There was a problem hiding this comment.
The logic for parsing QueuedDate, StartDate, and FinishDate is duplicated. This makes the code harder to read and maintain. Consider extracting this logic into a helper function. For example:
func parseTime(layout, value, fieldName string) (time.Time, error) {
t, err := time.Parse(layout, value)
if err != nil {
return time.Time{}, fmt.Errorf("failed to parse %s: %w", fieldName, err)
}
return t, nil
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 5566 Click here to see the affected service packages
Action takenFound 671 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Got at least ~440 tests recorded on TC. Triggering a rerun now /gcbrun |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 5564 Click here to see the affected service packages
Action takenFound 260 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
shuyama1
left a comment
shuyama1
left a comment
There was a problem hiding this comment.
Let's ensure the YAML linting errors and related test failures are resolved in the next sync.
BBBmau
merged commit 625c184
into
GoogleCloudPlatform:FEATURE-BRANCH-resource-identity
20 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.