sync universal deletion feature branch march 17#16745
Conversation
…rtificates.0.managed.0.provisioning_issue.0.details` (GoogleCloudPlatform#16556)
…le_compute_region_network_firewall_policy_rule (GoogleCloudPlatform#16608)
GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>
…ogflow_conversation_profile` (beta) (GoogleCloudPlatform#16696)
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Multiple resources addedThis PR adds multiple new resources: Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_region_network_firewall_policy_rule" "primary" {
target_forwarding_rules = # value needed
}
Resource: resource "google_compute_router_named_set" "primary" {
elements {
location = # value needed
}
}
Resource: resource "google_container_cluster" "primary" {
node_pool {
network_config {
subnetwork = # value needed
}
}
}
Resource: resource "google_container_node_pool" "primary" {
network_config {
subnetwork = # value needed
}
}
Resource: resource "google_dataproc_cluster" "primary" {
cluster_config {
cluster_tier = # value needed
cluster_type = # value needed
staging_bucket = # value needed
temp_bucket = # value needed
}
}
Resource: resource "google_network_security_ull_mirroring_collector" "primary" {
engine = # value needed
forwarding_rule = # value needed
labels = # value needed
location = # value needed
ull_mirroring_collector_id = # value needed
}
Resource: resource "google_network_security_ull_mirroring_engine" "primary" {
labels = # value needed
location = # value needed
ull_mirroring_engine_id = # value needed
}
Resource: resource "google_sql_provision_script" "primary" {
database = # value needed
description = # value needed
instance = # value needed
script = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 6116 Click here to see the affected service packages
Action takenFound 45 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
NickElliot
merged commit 84cc95e
into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policy
19 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.