Skip to content

Honor approver collapse preference in review email - #751

Merged
jochengcd merged 1 commit into
GrandComicsDatabase:betafrom
jhunterjActual:fix/approver-email-collapse
Sep 3, 2026
Merged

Honor approver collapse preference in review email#751
jochengcd merged 1 commit into
GrandComicsDatabase:betafrom
jhunterjActual:fix/approver-email-collapse

Conversation

@jhunterjActual

Copy link
Copy Markdown
Contributor

Summary

  • honor the assigned approver's collapsed compare-view preference in the “GCD change to review” email
  • preserve the existing expanded link when that preference is disabled
  • document that the compare route currently has no query parameters and must merge any future ones
  • add regression coverage for both preference values

Testing

  • pytest gcd-django/apps/oi/tests/test_views.py
  • python manage.py check
  • python -m flake8 apps/oi/views.py apps/oi/tests/test_views.py
  • git diff --check
  • mounted runtime health check returned HTTP 200

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the submission email logic to respect the approver's preference for collapsing the compare view by appending ?collapse=1 to the comparison URL when enabled, and adds a corresponding test case. The review feedback suggests adding a defensive check to ensure the approver has an associated Indexer profile before accessing its attributes, preventing potential RelatedObjectDoesNotExist exceptions.

Comment thread apps/oi/views.py Outdated
@jhunterjActual
jhunterjActual force-pushed the fix/approver-email-collapse branch from 2da70ca to 319ca09 Compare September 2, 2026 20:22
@jhunterjActual
jhunterjActual marked this pull request as ready for review September 2, 2026 20:30
@jochengcd
jochengcd merged commit ca05c37 into GrandComicsDatabase:beta Sep 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants