Introduce typed id value classes - #229
Open
m4pl wants to merge 12 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
m4pl
force-pushed
the
task/173/219-typed-value-classes
branch
from
August 3, 2026 20:20
4cf3f83 to
941abc6
Compare
m4pl
marked this pull request as ready for review
August 3, 2026 20:30
RankoR
reviewed
Aug 3, 2026
| val messageId = data.messageId?.takeIf { it.isNotBlank() } | ||
| val conversationId = data.conversationId?.takeIf { it.isNotBlank() } | ||
|
|
||
| if (messageId == null || conversationId == null) { |
RankoR
reviewed
Aug 3, 2026
| internal const val PARTICIPANT_ID_1 = "p1" | ||
| internal const val PARTICIPANT_ID_2 = "p2" | ||
| internal const val PARTICIPANT_ID_3 = "p3" | ||
| internal val PARTICIPANT_ID_1 = ParticipantId("p1") |
Contributor
There was a problem hiding this comment.
Should be participantId1 as it's not const anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219
Adds value classes
ConversationId,MessageId,ParticipantId,SubId. Primitives stay at persistence and Java boundaries via.value/fromOrNull.Behavior changes:
ConversationMessageUiModelMapper.mapreturnsnullinstead of a blankmessageId, which previously became a duplicateLazyColumnkey. SomeisEmpty()checks becameisBlank(), since the id types only expose blank checks.