Fix "Test against stream" dropdown closing on scroll - #25849
Merged
Conversation
Contributor
|
I noticed the "close on scroll" issue can also be fixed by adding |
Contributor
|
It improves the behavior, but the new popover can still close on scroll in some cases, which might be annoying. I suggest we add Another thought, there is this issue about the issue of loading all streams #21543. I am not sure how difficult it is, but this might be a good opportunity to implement the paginated streams endpoint for this use case. |
Replace the `DropdownButton`/`MenuItem` implementation with `SelectPopover`, which uses `OverlayTrigger` with `rootClose` (closes on click-outside only, not on scroll). This fixes the UX issue where scrolling a long stream list would immediately close the dropdown. Also adds a built-in text filter input for quickly finding streams.
Replace the prop-based stream list (fetched all at once) with a paginated fetch using the existing useStreams hook against /streams/paginated. The SelectPopover is replaced with an OverlayTrigger-based popover that includes a debounced search input, a paginated ListGroup of streams, and PaginatedList navigation controls (page size 10). Removes the allStreams prop from MessageActions, MessageDetail, MessageTableEntry, and ShowMessagePage since streams are now fetched directly inside TestAgainstStreamButton.
linuspahl
approved these changes
Jun 2, 2026
dennisoelkers
pushed a commit
that referenced
this pull request
Jun 4, 2026
* Fix "Test against stream" dropdown closing on scroll Replace the `DropdownButton`/`MenuItem` implementation with `SelectPopover`, which uses `OverlayTrigger` with `rootClose` (closes on click-outside only, not on scroll). This fixes the UX issue where scrolling a long stream list would immediately close the dropdown. Also adds a built-in text filter input for quickly finding streams. * Add pull request reference to issue 18694 * Use paginated streams endpoint in 'Test against stream' popover Replace the prop-based stream list (fetched all at once) with a paginated fetch using the existing useStreams hook against /streams/paginated. The SelectPopover is replaced with an OverlayTrigger-based popover that includes a debounced search input, a paginated ListGroup of streams, and PaginatedList navigation controls (page size 10). Removes the allStreams prop from MessageActions, MessageDetail, MessageTableEntry, and ShowMessagePage since streams are now fetched directly inside TestAgainstStreamButton. * Remove useCallback wrapper — React Compiler handles memoization * Fix duplicate id on stream filter input; use findBy in tests * Fix TS error: move title to span inside disabled ListGroupItem * Display stream names as actual links. * Fixing linter hints --------- Co-authored-by: Linus Pahl <linus.pahl@graylog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the
DropdownButton/MenuItem-based "Test against stream" UI withSelectPopover, an existing reusable component backed byOverlayTriggerwithrootClose.Motivation and Context
Mantine
Menu(which backsDropdownButton) closes on scroll events originating outside the menu. When a user has many streams and the list is taller than the viewport, scrolling to find a stream immediately dismissesthe dropdown, making it unusable.
SelectPopoverusesrootClose(closes on click-outside only, not on scroll) and includes a built-in text filter input, making it a better fit for this use case.How Has This Been Tested?
MessageActions.test.tsx)Screenshots (if appropriate):
Fixes #18694
Types of changes
Checklist: