Skip to content

CodeRabbit Generated Unit Tests: Add Generated Unit Tests for PR Changes - #7

Merged
MisterWanted merged 2 commits into
mainfrom
coderabbitai/utg/a6611c8
Aug 21, 2026
Merged

CodeRabbit Generated Unit Tests: Add Generated Unit Tests for PR Changes#7
MisterWanted merged 2 commits into
mainfrom
coderabbitai/utg/a6611c8

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Unit test generation was requested by OnlineChef (@ChefGroep).

The following files were modified:

  • crates/fff-core/tests/bigram_overlay_coherence_test.rs

Greptile Summary

The bigram bitmap iteration update preserves expected indexing behavior, and the expanded integration coverage exercises picker readiness, shutdown, and file-update paths.

Confidence Score: 5/5

No blocking failure remains.

No blocking failure remains.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the focused long-content bigram-filter tests and the complete index::bigram_filter library-test module; all tests passed with exit code 0, confirming the fixed-size bitmap chunk traversal preserves the reference bigram set.
  • Mapped the source ranges and test oracles for bigram_filter and observed that the validation reports 1/1, 1/1, and 14/14 passing tests with exit code 0.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "fix(clippy): use as_chunks::<8> instead ..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fb2c3602-9389-4bd8-b6a3-3ef869703aea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Comment on lines +1698 to +1700
fn wait_for_bigram_times_out_when_picker_never_published() {
let shared_picker = SharedFilePicker::default();
wait_for_bigram(&shared_picker);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty-picker timeout test adds a fixed ten-second delay

wait_for_bigram_times_out_when_picker_never_published passes an empty SharedFilePicker to wait_for_bigram, so it cannot become ready. The helper polls until its production ten-second deadline before the expected panic; the isolated test took 10.03 seconds. This adds a fixed ten-second delay to local and CI runs of the integration test target. Parameterize the helper deadline or supply a short test-specific timeout for this intentional timeout-path coverage.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Artifacts

Initial targeted test invocation with incorrect package name

  • The attempted targeted Cargo command was executed from the repository root and failed because the package is named `fff-search`, identifying the required package selector.

Targeted empty-picker timeout test completing after ten seconds

  • The corrected targeted Cargo test was executed from the repository root; it reached the expected timeout panic and passed in 10.03 seconds, confirming the fixed delay.

View artifacts

T-Rex Ran code and verified through T-Rex

Fix in Cursor Fix in Claude Code

@MisterWanted
MisterWanted merged commit daf3d04 into main Aug 21, 2026
22 checks passed
@MisterWanted
MisterWanted deleted the coderabbitai/utg/a6611c8 branch August 21, 2026 21:41
MisterWanted added a commit that referenced this pull request Aug 22, 2026
* build(deps): bump pyo3 from 0.24.2 to 0.29.0

Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.24.2 to 0.29.0.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.24.2...v0.29.0)

---
updated-dependencies:
- dependency-name: pyo3
  dependency-version: 0.29.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(bindings): migrate fff-python to pyo3 0.29 API

- Python::allow_threads -> Python::detach (renamed in 0.26)
- Python::with_gil -> Python::attach (removed in 0.29)
- PyObject alias -> Py<PyAny> (gil-refs cleanup)
- explicit PyAny import alongside prelude glob

* fix(clippy): as_chunks::<8> instead of chunks_exact(8) (same as #7)

* fix(bindings): opt in to pyo3 0.29 from_py_object on Clone pyclasses

pyo3 0.29 deprecates the automatic FromPyObject impl for Clone pyclasses;
13 data structs now explicitly opt in via #[pyclass(from_py_object)].

* fix(bindings): skip_from_py_object instead of opt-in (types carry manual FromPyObject impls)

The from_py_object opt-in conflicts with the existing manual
FromPyObject implementations on these types (E0119 conflicting
DerefToPyAny). Skipping the automatic impl preserves current behavior.

* fix(bindings): collapse duplicated pyclass attributes

* fix(bindings): remove remaining duplicated plain pyclass attributes

* chore(review): retrigger code review pass — no content changes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: chefadmin-netizen <chefadmin@chefgroep.online>
Co-authored-by: MisterWanted <joepsy01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants