Take the member list grouping from @gryt/core - #390
Merged
Conversation
The phone drew the same list from its own copy of the same rules. core#8 has the one implementation and this drops the desktop's, which is 70 lines of the 90-line file. Nothing about this app changes. The rules the two had drifted on were the phone's — a member with no `status` was offline there and present here, and core kept this reading — so the desktop's output is the same list it was. `readableRoleColor` stays. It emits a CSS `oklch()` string React Native cannot use, and was settled as a non-candidate on the task. `groupMembersByRole` is re-exported from the same file rather than repointed at the call site, because MemberSidebar wants both and moving one import is not worth the churn. Needs @gryt/core 0.5.0, so the pin moves from ^0.4.0. Red until that ships. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red on one line, and it is the expected one:
Couldn't find any versions for "@gryt/core" that matches "^0.5.0". core#8 is merged but not released — npm is still on 0.4.0. This goes green on a 0.5.0 release plus the matchingyarn.lockbump, which I will push the moment the version exists rather than writing a lockfile entry for a version that does not.The phone drew the same list from its own copy of the same rules. core#8 has the one implementation and this drops the desktop's, 70 lines of a 90-line file.
Nothing about this app changes. The rule the two had drifted on was the phone's — a member with no
statuswas offline there and present here — and core kept this reading, so the desktop's output is the same list it was.readableRoleColorstays in this file. It emits a CSSoklch()string React Native cannot use, and was settled as a non-candidate on the task.groupMembersByRoleis re-exported from the same file rather than repointed at the call site, because MemberSidebar wants both and moving one import is not worth the churn.Typechecked against core's build locally —
memberGroups.tsandMemberSidebar.tsxare clean, andMemberInfoandServerRoleSummarysatisfy the generic without either having to adopt a type from core.Part of GRYT-898, which this and the mobile half finish.
🤖 Generated with Claude Code