Draw the three printing sites the client now knows about (GRYT-913) - #396
Closed
sivert-io wants to merge 1 commit into
Closed
Draw the three printing sites the client now knows about (GRYT-913)#396sivert-io wants to merge 1 commit into
sivert-io wants to merge 1 commit into
Conversation
main is red, and has been since #390. `check-embed-icons` refuses a provider `@gryt/core` names with no artwork here: providers in @gryt/core with no icon here: makerworld, printables, thingiverse My doing. core#10 added the three providers, #390 moved the client to `@gryt/core` 0.5.0, and the artwork went into core#11 rather than here — because core#9 had moved every logo into the package as path data on the same day, and I took that to mean this file was on its way out. It is on its way out, but it is not out yet: `CardSite` still reads `PROVIDER_ICONS`, so until it reads `getProviderLogo` instead, a provider without an entry here is a failing check and a missing logo. Three entries, and the import list re-wrapped because the autofix left it ragged. MakerWorld wears Bambu Lab's mark, the same reason its provider entry wears their green. Follow-up worth doing separately: `CardSite` reading `getProviderLogo` from the package would delete this file and the `react-icons` dependency behind it, and would give the phone the same logos. That is core#9's whole point and it is a bigger change than a red main should wait for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
Superseded by #395, which landed the proper fix ten minutes after this was opened: This adds three entries to a file that no longer exists, so there is nothing here worth keeping. #395 is the better answer to the same red The logos themselves are already in the package (core#11), so MakerWorld, Printables and Thingiverse draw correctly on main today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red and has been since #390 — three commits.check-embed-iconsrefuses a provider@gryt/corenames with no artwork here:My doing. core#10 added the three providers, #390 moved the client to
@gryt/core0.5.0, and I put the artwork in core#11 rather than here — because core#9 had moved every logo into the package as path data on the same day, and I read that as this file being on its way out.It is on its way out. It is not out yet:
CardSitestill readsPROVIDER_ICONS, so until it readsgetProviderLogoinstead, a provider with no entry here is a failing check and a missing logo.Three entries. The import list is re-wrapped because the autofix left it ragged. MakerWorld wears Bambu Lab's mark — the same reason its provider entry wears their green.
Verification
yarn lint(tsc -b+ eslint,--max-warnings 0) passes, as dotest:card-byline,test:server-noticeandtest:identity-certificate. Confirmed against the installed@gryt/core0.6.0:Follow-up, deliberately not here
CardSitereadinggetProviderLogofrom the package would delete this file and thereact-iconsdependency behind it, and would give the phone the same logos — core#9's whole point. That is a bigger change than a redmainshould wait for, so it wants its own PR.🤖 Generated with Claude Code