Move the client to @gryt/core 0.6.0 - #394
Merged
Merged
Conversation
0.5.0 brought the provider logos, 0.6.0 adds the marks for the three printing sites. The caret does not reach either on its own: on a 0.x package ^0.5.0 means >=0.5.0 <0.6.0, so every core minor needs both apps bumped by hand. Nothing here uses the new entries yet. The client still draws provider logos from react-icons, and moving it to core's LINK_PROVIDER_LOGOS is its own change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sivert-io
added a commit
that referenced
this pull request
Sep 4, 2026
main is red. #394 moved the client to @gryt/core 0.6.0, which brought three new providers — makerworld, printables, thingiverse — and check-embed-icons caught that this app had no artwork for them. It was right to. Adding them to the old table was not possible for all three: react-icons has SiPrintables and SiThingiverse but no SiMakerworld, while the package has all 76 marks. So the artwork comes from the package now, which is where it was always headed. The card renders the path rather than a component. The class already sets size and colour, so currentColor is all the svg has to say, and 15px against a 24x24 viewBox is what it drew before. embedProviderIcons.ts is gone, and check-embed-icons with it. That check guarded a seam — the package owning the list while this app owned the artwork — and the seam is what closed. Both sides live in the package, so they cannot drift, and core's own logos.test.ts already asserts every mark names a real provider. react-icons/si is out of this app. react-icons stays for now: the 129 phosphor icons and SiKofi and FaGithub in settings still come from it. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.5.0 brought the provider logos, 0.6.0 adds the marks for the three printing
sites.
The caret does not reach either on its own. On a 0.x package
^0.5.0means>=0.5.0 <0.6.0, so every core minor needs both apps bumped by hand — thematching mobile bump is mobile#196,
which goes two minors at once because it had been sitting on 0.4.0.
Nothing here uses the new entries yet. The client still draws provider logos from
react-icons, and moving it to core's
LINK_PROVIDER_LOGOSis its own change —that one also drops react-icons entirely, which is 82MB off every checkout and
nothing off the installer, since it is already a devDependency and out of the
asar.
Lint and typecheck pass.
🤖 Generated with Claude Code