Draw provider logos from the package, and fix main - #395
Merged
Conversation
main is red. #394 moved the client to @gryt/core 0.6.0, which brought three new providers — makerworld, printables, thingiverse — and check-embed-icons caught that this app had no artwork for them. It was right to. Adding them to the old table was not possible for all three: react-icons has SiPrintables and SiThingiverse but no SiMakerworld, while the package has all 76 marks. So the artwork comes from the package now, which is where it was always headed. The card renders the path rather than a component. The class already sets size and colour, so currentColor is all the svg has to say, and 15px against a 24x24 viewBox is what it drew before. embedProviderIcons.ts is gone, and check-embed-icons with it. That check guarded a seam — the package owning the list while this app owned the artwork — and the seam is what closed. Both sides live in the package, so they cannot drift, and core's own logos.test.ts already asserts every mark names a real provider. react-icons/si is out of this app. react-icons stays for now: the 129 phosphor icons and SiKofi and FaGithub in settings still come from it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red. #394 moved the client to
@gryt/core0.6.0, which brought threenew providers —
makerworld,printables,thingiverse— andcheck-embed-iconscorrectly failed because this app had no artwork for them.Adding them to the old table would not have worked for all three: react-icons
has
SiPrintablesandSiThingiversebut noSiMakerworld. The package hasall 76 marks, so the artwork comes from there now — which is where it was headed
anyway.
What changed
LinkPreviewCardrenders the path instead of a component:.link-embed-card-brandalready setswidth: 15px,height: 15pxandcolor,so this draws exactly what react-icons drew — same 15px against the same 24×24
viewBox, same
currentColor.Two deletions worth arguing with
embedProviderIcons.ts— 108 lines and 73react-icons/siimports, all nowin the package.
scripts/check-embed-icons.mjs— this guarded a seam its own commentdescribed: "the package owns the provider list, this app owns the artwork, and
the two can drift apart". That seam is what closed. Both sides live in the
package now, so they cannot drift, and core's
logos.test.tsalready assertsevery mark names a real provider. Keeping the check would mean keeping a file
whose only job is to compare the package against itself.
I checked the coverage it was protecting before deleting it: 76 providers, 76
logos, none missing, including the three that broke the build.
Not the whole icon story
react-iconsstays installed. The 129 phosphor icons still come fromreact-icons/pi, andSiKofiandFaGithubare in settings. Dropping thedependency entirely is the follow-up, and it is worth 82 MB of every checkout
and nothing at all off the installer, since it is already a devDependency and
out of the asar.
Lint, typecheck and build pass.
🤖 Generated with Claude Code