Give the three printing sites their marks (GRYT-913) - #11
Merged
Conversation
core#10 added MakerWorld, Printables and Thingiverse as providers. core#9 moved the artwork into this package the same day. The two crossed, so 0.5.0 went out with three sites that have a name and a brand colour and fall back to a favicon where the logo should be. MakerWorld wears Bambu Lab's mark, for the reason its provider entry already gives for wearing their green: it is Bambu Lab's site and has none of its own. The count in `logos.test.ts` goes 73 to 76. It is there so a logo cannot go missing quietly, which is exactly what happened here — worth keeping, and worth the second test naming these three, since a provider without artwork is a deliberate state elsewhere in the file and cannot be caught by a rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10 added MakerWorld, Printables and Thingiverse as providers. #9 moved the artwork into this package on the same day. The two crossed, so 0.5.0 shipped three sites that have a name and a brand colour and fall back to a favicon where the logo should be.
Adds the three path entries. MakerWorld wears Bambu Lab's mark, for the reason its provider entry already gives for the green — it is Bambu Lab's site and has none of its own.
The count
logos.test.tsasserts an exact number, and the comment explains why: a logo going missing is a regression nobody files. It goes 73 → 76.That check is the reason this was caught, so it earns its keep. But it could not have prevented it: the file deliberately allows a provider with no artwork, since falling back to a favicon is a valid state. So there is a second test naming these three specifically.
Verification
npm run typecheck,npm test(83) andcheck-public-surfaceall pass. Every path is a single command string on the documented 24×24 canvas, whichlogos.test.tsalready asserts for all of them.Mutation-tested:
After this
Needs a release for the clients to see it — the desktop is on
@gryt/core^0.4.0and the phone the same, so neither has 0.5.0 yet either.🤖 Generated with Claude Code