fix(lint): use plain node:assert import in allowread-fail-closed test - #1612
Merged
Conversation
The runLinter CI job (oxlint --quiet) fails on a single error: the no-restricted-imports rule forbids importing from 'node:assert/strict' (.oxlintrc.json), directing to plain node:assert whose strictEqual/ok named exports are already strict. Switch the import path to match the repo-wide convention used by sibling integration tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
requested review from
Ethan-Arrowood,
cb1kenobi,
heskew and
kriszyp
July 6, 2026 14:11
Contributor
|
Reviewed; no blockers found. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import statement in integrationTests/resources/allowread-fail-closed.test.ts to import ok and strictEqual from node:assert instead of node:assert/strict. There are no review comments, and I have no feedback to provide.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the
runLinterCI failure onmain.The
runLinterjob runsnpm run lint:required(oxlint --quiet), which fails on a single error:The repo's
.oxlintrc.jsonrestricts imports fromnode:assert/strict(andassert/strict):Change
One line — switch the import from
node:assert/strictto plainnode:assert:node:assert's namedok/strictEqualare already the strict variants, so behavior is unchanged. This also matches the convention used across sibling integration tests (import { ok, strictEqual } from 'node:assert').Verification
npm run lint:required(the CI command) → 0 errors (previously 1).prettier --checkon the file → clean.Note:
mainalso currently failsUnit Test(flaky event-ordering assertions, e.g. "expected at least 1 event for id=1, got 0"); that's a separate issue and out of scope for this lint-only fix.🤖 Generated with Claude Code