chore(deps): update dependency globals to v17 - #1608
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
c75fde7 to
9b43da9
Compare
dawsontoth
left a comment
There was a problem hiding this comment.
Reviewed via automated Renovate check.
Diff: globals ^16.5.0→^17.0.0 (resolved 17.7.0) — a dev-only lint-tooling dependency + lockfile. No source changes.
Local verification (Node 24, npm ci):
lint(oxlint): 7 problems (1 error, 6 warnings) — byte-for-byte identical to themainbaseline. The globals v17 bump introduces zero new lint problems.format:check(prettier): ✅ clean.
On the red CI: the failing runLinter and Unit Test checks are pre-existing on main — the latest push to main is itself red on both (Lint fails on integrationTests/resources/allowread-fail-closed.test.ts:14 no-restricted-imports for node:assert/strict; Unit Test fails on flaky event-ordering assertions "expected at least 1 event for id=1, got 0"). None of this is caused by this bump, and globals (a dev lint-config helper) cannot affect the runtime unit tests. Those failures need a separate fix on main; a rebase will carry it in once main is green.
The dependency change itself is safe — approving. (Merge will still gate on the branch going green after main's pre-existing lint/unit breakage is resolved.)
9b43da9 to
d4d1ba2
Compare
kriszyp
left a comment
There was a problem hiding this comment.
Reviewed via Claude review-queue — devDependency-only globals v16->v17 bump, unused directly by the oxlint config. CI failure is the known pre-existing node:assert/strict lint issue (fix already merged in #1612), unrelated to this PR. LGTM.
This PR contains the following updates:
^16.5.0→^17.0.0Release Notes
sindresorhus/globals (globals)
v17.7.0Compare Source
v17.6.0Compare Source
00a4dd9v17.5.0Compare Source
5d84602v17.4.0Compare Source
d43a051v17.3.0Compare Source
295fba9v17.2.0Compare Source
jasmine: AddthrowUnlessandthrowUnlessAsyncglobals (#335)97f23a7v17.1.0Compare Source
webpackandrspackglobals (#333)65cae73v17.0.0Compare Source
Breaking
audioWorkletenvironment frombrowser(#320)7bc293eImprovements
ebe1063chromeandfirefox(#321)59ceff8bunBuiltinenvironment (#324)1bc6e3bdenoBuiltinenvironment (#324)1bc6e3bpaintWorkletenvironment (#323)4b78f56sharedWorkerenvironment (#322)4a02a85Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.