Skip to content

fix(normalizer): normalize Delphi source line endings to CRLF on Windows (issue #197) - #248

Merged
snakeice merged 2 commits into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-197-crlf-normalization
Jul 16, 2026
Merged

fix(normalizer): normalize Delphi source line endings to CRLF on Windows (issue #197)#248
snakeice merged 2 commits into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-197-crlf-normalization

Conversation

@isaquepinheiro

Copy link
Copy Markdown
Contributor

This PR automatically normalizes line endings of Delphi files (.pas, .dfm, etc.) to CRLF when packages are downloaded on Windows systems, preventing compiler syntax errors caused by Unix LF endings.

@HashLoad HashLoad deleted a comment from codecov-commenter Jul 7, 2026
golangci-lint usetesting: replace os.MkdirTemp with t.TempDir()
which automatically handles cleanup.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0f2a917). Learn more about missing BASE report.

Files with missing lines Patch % Lines
utils/normalizer/line_normalizer.go 77.77% 3 Missing and 3 partials ⚠️
internal/core/services/installer/core.go 0.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage        ?   25.82%           
=======================================
  Files           ?       83           
  Lines           ?     3876           
  Branches        ?        0           
=======================================
  Hits            ?     1001           
  Misses          ?     2798           
  Partials        ?       77           
Flag Coverage Δ
unittests 25.82% <67.74%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snakeice

Copy link
Copy Markdown
Member

Rebased on main. CI retriggering...

@snakeice
snakeice merged commit dd78759 into HashLoad:main Jul 16, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants