feat(cudf): Support multi-column RANGE Window aggregates - #20
Merged
winningsix merged 4 commits intoJul 21, 2026
Merged
Conversation
Selective Build Plan
Selective build plan |
thirtiseven
marked this pull request as ready for review
July 21, 2026 07:59
…umn-range-window # Conflicts: # velox/experimental/cudf/exec/CudfWindow.cpp
Collaborator
Author
|
Updated onto the latest Validation after the merge:
No benchmark query was rerun for this conflict refresh. |
winningsix
approved these changes
Jul 21, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RANGEWindow frames with multipleORDER BYcolumns, including mixed directions and null orderingWhy
The cuDF Window adapter assumed that aggregate
RANGEframes had a single ordering key. Spark workloads with multiple ordering columns were therefore rejected under strict cuDF replacement, even though the input was already correctly partitioned and sorted. Once that path was enabled, wide nested payloads also exposed two exchange lifetime and batching issues: concatenation could grow without a byte bound, and sliced nested columns could outlive their backing storage during UCX partitioning.Impact
Multi-column aggregate
RANGEwindows can stay fully native and stream bounded batches through MPP. The exchange changes keep wide and nested payloads bounded and owned across asynchronous partition delivery.Validation
Companion PR
NVIDIA/spark-gluten#71 carries the Spark planner, exchange configuration, and multi-peer root placement changes.