test_bot fixes for portable formulae

[cho-m]

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• AI was used to generate or assist with generating this PR.

---

test_bot/formulae: run nested test-bot in temporary dir

This provides a clean directory to test bottling so that previously built bottles don't cause "Unexpected bottle" errors

https://github.com/Homebrew/homebrew-core/actions/runs/29179553748/job/86656464924#step:4:1833

 ==> Running Formulae#run!
  Error: Unexpected bottle JSON: /github/home/bottles/portable-ruby--4.0.5_1.arm64_linux.bottle.json
  Error: Unexpected bottle tarball: /github/home/bottles/portable-ruby--4.0.5_1.arm64_linux.bottle.tar.gz

Mktemp#run should be similar to Dir.mktmpdir { Dir.chdir { ... } }. Could use latter if preferred (need to change directory so that Pathname.pwd runs in clean directory).

---

test_bot/formulae_detect: exclude portable when testing default

This avoids trying to rebuild portable formulae again within the nested test-bot run which may the cause of stalled runs

[Copilot]

Pull request overview

This PR adjusts Homebrew’s test_bot behavior around portable formulae to reduce flaky/stalled CI runs: it runs a nested brew test-bot in a clean temporary working directory to avoid “Unexpected bottle” artifacts, and it prevents portable formulae from being selected when running --test-default-formula.

Changes:

• Run the nested brew test-bot --test-default-formula inside an Mktemp directory to isolate bottle artifacts.
• When --test-default-formula is used, filter out portable-* formulae from the detected added/modified sets to avoid rebuilding them in that run.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
Library/Homebrew/test_bot/formulae.rb	Wrap nested brew test-bot invocation in Mktemp to run in a clean temporary directory.
Library/Homebrew/test_bot/formulae_detect.rb	Exclude portable-* formulae from detection when --test-default-formula is enabled.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[carlocab]

test_bot/formulae: run nested test-bot in temporary dir

This provides a clean directory to test bottling so that previously built bottles don't cause "Unexpected bottle" errors

Homebrew/homebrew-core/actions/runs/29179553748/job/86656464924#step:4:1833

 ==> Running Formulae#run!
  Error: Unexpected bottle JSON: /github/home/bottles/portable-ruby--4.0.5_1.arm64_linux.bottle.json
  Error: Unexpected bottle tarball: /github/home/bottles/portable-ruby--4.0.5_1.arm64_linux.bottle.tar.gz

Mktemp#run should be similar to Dir.mktmpdir { Dir.chdir { ... } }. Could use latter if preferred (need to change directory so that Pathname.pwd runs in clean directory).

Isn't this a bug in how we track bottles that we expect to be there? We should fix that instead.

[cho-m]

Isn't this a bug in how we track bottles that we expect to be there? We should fix that instead.

I think it is behaving as expected since we want 0 bottles to exist at beginning of a test-bot run to guarantee a clean environment.

The test is for verifying we can build bats-core and libdeflate imitating the CI workflow in Homebrew/brew,

brew/.github/workflows/tests.yml

Lines 410 to 414 in 0eb3803

	- run: brew test-bot --only-cleanup-before
	- run: brew test-bot --only-setup
	- run: brew test-bot --only-formulae --only-json-tab --test-default-formula

---

EDIT: could trigger the same --only-cleanup-before instead or manually remove them, but not sure if we want to delete the portable Ruby bottles

brew/Library/Homebrew/test_bot/cleanup_before.rb

Line 17 in 0eb3803

Pathname.glob("*.bottle*.*").each(&:unlink)

[MikeMcQuaid]

Thanks!