Fix more test failures#23088
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Homebrew’s RSpec suite to address two observed CI failures by making the affected specs more deterministic in environments with global macOS simulation settings and parallel trust-store interactions.
Changes:
- Unset
HOMEBREW_FAKE_MACOSin theMacOSVersion.kernel_major_versionspec to ensure it matches the realOS.kernel_versionon macOS runners. - Run the caskroom “old token” de-duplication spec under the
:trust_storeshared context to isolate the trust store per example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/test/macos_version_spec.rb | Ensures the kernel-major-version assertion isn’t affected by globally-set HOMEBREW_FAKE_MACOS. |
| Library/Homebrew/test/cask/caskroom_spec.rb | Runs the cask rename/de-duplication spec with isolated trust-store state to avoid cross-test interference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
18 tasks
carlocab
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?More test failure fixes.
https://github.com/Homebrew/homebrew-core/actions/runs/29278992918/job/86917281683?pr=292807#step:3:231
https://github.com/Homebrew/homebrew-core/actions/runs/29278992918/job/86917281683?pr=292807#step:3:100