Dockerfile: set cache location

[jonchang]

When running docker pull linuxbrew/brew && docker run linuxbrew/brew brew test-bot it fails with:

==> brew update-test
Error: Permission denied @ dir_s_mkdir - /root/.cache

This sets XDG_CACHE_HOME to /home/linuxbrew/.cache to prevent this issue.

[sjackman]

The default user in the Docker container is root, and root should have write permission to its home directory /root/.cache. Have you changed users to for example linuxbrew?

[jonchang]

The default user in the Docker container is root, and root should have write permission to its home directory /root/.cache. Have you changed users to for example linuxbrew?

There's something going on where docker run commands are getting prefixed with sudo -u #1000 running as the linuxbrew user. I'm not sure where this is happening, or if it's an issue with my local setup.

[sjackman]

$ docker pull linuxbrew/brew
$ docker run --rm linuxbrew/brew id
uid=0(root) gid=0(root) groups=0(root)

What do you see?

[sjackman]

The default user in linuxbrew/linuxbrew is 1000(linuxbrew).

[jonchang]

I think test-bot is doing something weird. I will investigate further. This happens on both macOS machines I have access to.

$ docker run --rm linuxbrew/brew id
uid=0(root) gid=0(root) groups=0(root)

test-bot:

$ docker run --rm linuxbrew/brew brew test-bot
Updating Homebrew...
warning: unable to access '/root/.config/git/attributes': Permission denied
[snip]
==> Tapping homebrew/test-bot
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot'...
warning: unable to access '/root/.config/git/attributes': Permission denied
Tapped 1 command and 1 formula (49 files, 262KB).
Error: Permission denied @ dir_s_mkdir - /root/.cache
Error: Failure while executing; `/usr/bin/sudo -u \#1000 /home/linuxbrew/.linuxbrew/bin/brew tap homebrew/test-bot` exited with 1.

Not test-bot:

$ docker run --rm linuxbrew/brew brew tap homebrew/test-bot
Updating Homebrew...
[snip]
==> Tapping homebrew/test-bot
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot'...
Tapped 1 command and 1 formula (49 files, 262KB).

[sjackman]

Error: Failure while executing; `/usr/bin/sudo -u \#1000 /home/linuxbrew/.linuxbrew/bin/brew tap homebrew/test-bot` exited with 1.

This error is quite weird to me. Is test-bot trying to run sudo? I don't see that in the test-bot code.

[iMichka]

I am hit by this issue to on ubuntu. This was working fine previously:

==> Tapping linuxbrew/xorg
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/linuxbrew/homebrew-xorg'...
Tapped 150 formulae (185 files, 312.6KB).
/usr/bin/sudo -u #1000 /home/linuxbrew/.linuxbrew/bin/brew tap homebrew/test-bot
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/utils/lock.sh: line 27: /home/linuxbrew/.linuxbrew/var/homebrew/locks/update: Permission denied
flock: 200: Bad file descriptor
Error: Another active Homebrew update process is already in progress.
Please wait for it to finish or terminate it to continue.
==> Tapping homebrew/test-bot
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot'...
warning: unable to access '/root/.config/git/attributes': Permission denied
Tapped 1 command and 1 formula (49 files, 112.1KB).
Error: Permission denied @ dir_s_mkdir - /root/.cache
Error: Failure while executing; `/usr/bin/sudo -u \#1000 /home/linuxbrew/.linuxbrew/bin/brew tap homebrew/test-bot` exited with 1.
Homebrew/homebrew-test-bot e970dbb (Merge pull request #244 from woodruffw-forks/revert-rpath-rewriting)
ARGV: --ci-upload --bintray-org=linuxbrew --git-name=LinuxbrewTestBot --git-email=testbot@linuxbrew.sh

[iMichka]

Maybe there is an issue with this line?
https://github.com/Homebrew/brew/blob/master/Library/Homebrew/brew.rb#L118

[sjackman]

Yes! That's definitely the culprit. I hadn't found that line. Good sleuthing!

[iMichka]

Should we just remove it?

[sjackman]

Here's the commit that originally added that line: c4dcf8b

It addressed a use case of running sudo brew cask, which I don't believe is a supported method of running brew. This line is intended to sudo back to the Homebrew user before running brew tap. I suggest reverting this commit c4dcf8b.

[MikeMcQuaid]

@sjackman Sounds good to me.

[sjackman]

Superseded by PR #5917