brew: remove sudo call

[iMichka]

Closes #5865

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[sjackman]

+ sudo -E -u linuxbrew /home/linuxbrew/.linuxbrew/bin/brew test-bot
Error: Invalid tap name '{"name"=>"homebrew/test-bot", "user"=>"Homebrew", "repo"=>"test-bot", "path"=>"/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot", "installed"=>false, "official"=>true, "formula_names"=>[], "formula_files"=>[], "command_files"=>[], "pinned"=>false}'
Error: Failure while executing; `/home/linuxbrew/.linuxbrew/bin/brew tap \{\"name\"=\>\"homebrew/test-bot\",\ \"user\"=\>\"Homebrew\",\ \"repo\"=\>\"test-bot\",\ \"path\"=\>\"/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot\",\ \"installed\"=\>false,\ \"official\"=\>true,\ \"formula_names\"=\>\[\],\ \"formula_files\"=\>\[\],\ \"command_files\"=\>\[\],\ \"pinned\"=\>false\}` exited with 1.

Odd. I guess it needs possible_tap.name. Odd that it worked before. #{possible_tap} may be equivalent to possible_tap.to_s. It looks like we're getting possible_tap.inspect for some reason now.

[iMichka]

Odd. I guess it needs possible_tap.name. Odd that it worked before. #{possible_tap} may be equivalent to possible_tap.to_s. It looks like we're getting possible_tap.inspect for some reason now.

That's because each time I try to change something in brew, I stumble over weird things :)

Anyway, it is better to call .name, instead of relying on the .to_s implementation which may change.

[sjackman]

Thanks, Michka!

[MikeMcQuaid]

Good call, thanks @iMichka!

[sjackman]

This PR was reverted in PR #6010.

[iMichka]

cc @jonchang