Skip to content

Update to v0.8.0 settings - #3

Merged
janbrouwer merged 1 commit into
IFCJSON-Team:masterfrom
Moult:feature-ios-v0.8.0
May 29, 2025
Merged

Update to v0.8.0 settings#3
janbrouwer merged 1 commit into
IFCJSON-Team:masterfrom
Moult:feature-ios-v0.8.0

Conversation

@Moult

@Moult Moult commented Jun 26, 2024

Copy link
Copy Markdown

v0.8.0 of IfcOpenShell changes the way it handles settings. This should make it compatible I think.

FYI @aothms

v0.8.0 will officially be released late August but there will be a few test releases prior to that.

settings.USE_PYTHON_OPENCASCADE = True
settings.set(settings.USE_WORLD_COORDS, True)
settings.set(settings.EXCLUDE_SOLIDS_AND_SURFACES, False)
settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE)
settings.set('dimensionality', ifcopenshell.ifcopenshell_wrapper.CURVES_SURFACES_AND_SOLIDS)

The equivalent of EXCLUDE_SOLIDS_AND_SURFACES is called dimensionality now.

Andrej730 added a commit to IfcOpenShell/IfcOpenShell that referenced this pull request Jul 30, 2024
Bumped the version, so Blender would recognize the updated wheel.

Related IFCJSON-Team/IFC2JSON_python#3
@furgo16

furgo16 commented May 22, 2025

Copy link
Copy Markdown

At FreeCAD we're discussing how to best install this module to be able to export to .ifcjson. Looking at how Bonsai BIM does it, it seems it is downloading and installing the branch in this PR.

Now that ifcopenshell 0.8.x has been released, and for downstreams who want to use ifc2json5a, it would be great if these changes were merged upstream.

@janbrouwer @jbrouwerdigibase looking at the commit history, it would appear you're the maintainer. Would you have some time to review and eventually merge this PR? Thanks!

@janbrouwer
janbrouwer merged commit 8c7d6e0 into IFCJSON-Team:master May 29, 2025
Andrej730 added a commit to IfcOpenShell/IfcOpenShell that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants