Update to v0.8.0 settings - #3
Merged
Merged
Conversation
aothms
reviewed
Jun 26, 2024
| settings.USE_PYTHON_OPENCASCADE = True | ||
| settings.set(settings.USE_WORLD_COORDS, True) | ||
| settings.set(settings.EXCLUDE_SOLIDS_AND_SURFACES, False) | ||
| settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE) |
There was a problem hiding this comment.
Suggested change
| settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE) | |
| settings.set('dimensionality', ifcopenshell.ifcopenshell_wrapper.CURVES_SURFACES_AND_SOLIDS) |
The equivalent of EXCLUDE_SOLIDS_AND_SURFACES is called dimensionality now.
Andrej730
added a commit
to IfcOpenShell/IfcOpenShell
that referenced
this pull request
Jul 30, 2024
Bumped the version, so Blender would recognize the updated wheel. Related IFCJSON-Team/IFC2JSON_python#3
|
At FreeCAD we're discussing how to best install this module to be able to export to Now that ifcopenshell 0.8.x has been released, and for downstreams who want to use @janbrouwer @jbrouwerdigibase looking at the commit history, it would appear you're the maintainer. Would you have some time to review and eventually merge this PR? Thanks! |
Andrej730
added a commit
to IfcOpenShell/IfcOpenShell
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.8.0 of IfcOpenShell changes the way it handles settings. This should make it compatible I think.
FYI @aothms
v0.8.0 will officially be released late August but there will be a few test releases prior to that.