Skip to content

Update to v0.8.0 settings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janbrouwer merged 1 commit into from
May 29, 2025
Merged

Update to v0.8.0 settings #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion file_converters/ifcjson/ifc2json4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ class IFC2JSON4(common.IFC2JSON):
SCHEMA_VERSION = '0.0.1'

settings = ifcopenshell.geom.settings()
settings.set(settings.USE_WORLD_COORDS, False)

def __init__(self,
ifcModel,
Expand Down
5 changes: 2 additions & 3 deletions file_converters/ifcjson/ifc2json5a.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,8 @@ class IFC2JSON5a(common.IFC2JSON):
}

settings = ifcopenshell.geom.settings()
settings.USE_PYTHON_OPENCASCADE = True
settings.set(settings.USE_WORLD_COORDS, True)
settings.set(settings.EXCLUDE_SOLIDS_AND_SURFACES, False)
settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE)

@aothms aothms Jun 26, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
settings.set("iterator-output", ifcopenshell.ifcopenshell_wrapper.NATIVE)
settings.set('dimensionality', ifcopenshell.ifcopenshell_wrapper.CURVES_SURFACES_AND_SOLIDS)

The equivalent of EXCLUDE_SOLIDS_AND_SURFACES is called dimensionality now.

settings.set("use-world-coords", True)

def __init__(self, ifcModel,
COMPACT=False,
Expand Down