Skip to content

[FEATURE] Refinery: Add Decode group and Json transformation - #12034

Merged
lscharmer merged 1 commit into
ILIAS-eLearning:trunkfrom
mjansenDatabay:improvement/12/refinery-decode-group
Sep 7, 2026
Merged

[FEATURE] Refinery: Add Decode group and Json transformation#12034
lscharmer merged 1 commit into
ILIAS-eLearning:trunkfrom
mjansenDatabay:improvement/12/refinery-decode-group

Conversation

@mjansenDatabay

Copy link
Copy Markdown
Contributor

This commit suggests adding a Decode group and a Json transformation.

@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Sep 4, 2026

@lscharmer lscharmer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one note: Should the ConstraintViolationExceptions not be InvalidArgumnentException instead?
As this is a transformation not a constraint (and we are not validating smth.).

This commit suggests adding a `Decode` group and a
`Json` transformation.
@mjansenDatabay
mjansenDatabay force-pushed the improvement/12/refinery-decode-group branch from 6cb011a to a7063f2 Compare September 7, 2026 08:03
@mjansenDatabay

Copy link
Copy Markdown
Contributor Author

LGTM, just one note: Should the ConstraintViolationExceptions not be InvalidArgumnentException instead? As this is a transformation not a constraint (and we are not validating smth.).

@lscharmer Changed

@lscharmer
lscharmer merged commit 07557e0 into ILIAS-eLearning:trunk Sep 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants