Make : invalid in filenames in the Notebook JS code.

[ellisonbg]

This only prevents : in the filenames on the JavaScript side of things. Handling this on the server side will be a separate issue that is related to other open issue. I will update those to reflect this. Covers #1781.

[ellisonbg]

This addresses #1781.

[Carreau]

Wouldn't it be safer to make a notebook whitelist caracters (a-zA-Z0-9_.)?
Right now it seem to work with lots of caracters, but won't we ran into more issues when filename will start having éêßîü inside, not at webserver level, but filesystem level ? ( who said windows and spaces ?)

[minrk]

Unicode should be fine, and we definitely shouldn't force ascii. What should happen is failures to save with a particular name should be well-represented to the user, and not result in data-loss (certainly a failed rename should not result in removal of the original).

[Carreau]

I was thinking more of problem that can arrise with shell, when using space,$ and some other caractères.
For example a notebook name starting with #, it will be seen as a bash commentary in script.
But I guess this is more a discusion of filename vs notebook title, but as right now the two are the same we could allow any kind of caracters.

[minrk]

I was thinking more of problem that can arrise with shell, when using space,$ and some other caractères.
For example a notebook name starting with #, it will be seen as a bash commentary in script.
But I guess this is more a discusion of filename vs notebook title, but as right now the two are the same we could allow any kind of caracters.

But the notebook (and Python in general) has no problem at all with such things. If users are doing lots of bash scripting with their notebook files, they might choose space-less ASCII names for convenience. But there is no reason we should enforce something like that.

---

Reply to this email directly or view it on GitHub:
#1815 (comment)