Skip to content

Merge "develop" into "master" for 6.10 release#12233

Merged
pdurbin merged 937 commits intomasterfrom
develop
Mar 19, 2026
Merged

Merge "develop" into "master" for 6.10 release#12233
pdurbin merged 937 commits intomasterfrom
develop

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Mar 19, 2026

qqmyers and others added 30 commits February 24, 2026 15:26
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
…C/8914-COAR-compliant_messaging2

GDCC/8914 COAR Messaging Improvement
…rbidden (#12134)

* test: add test for duplicate role assignment

* feat: return 409 when creating duplicate role assignment
* updates to fix test

* add a few seconds - print duration
landreev and others added 21 commits March 18, 2026 12:39
Co-authored-by: landreev <leonid@hmdc.harvard.edu>
Co-authored-by: landreev <leonid@hmdc.harvard.edu>
…ble action

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@pdurbin pdurbin added this to the 6.10 milestone Mar 19, 2026
@pdurbin pdurbin requested a review from poikilotherm as a code owner March 19, 2026 17:04
Comment on lines +13 to +37
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6

- uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: '21'

- name: Set build number
run: scripts/installer/custom-build-number "${{ github.event.inputs.buildlabel }}"

- name: Build application war
run: mvn package

- name: Get war file name
working-directory: target
run: echo "war_file=$(ls *.war | head -1)">> $GITHUB_ENV

- name: Upload war artifact
uses: actions/upload-artifact@v7
with:
name: built-app
path: ./target/${{ env.war_file }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 9 hours ago

In general, the fix is to explicitly define GITHUB_TOKEN permissions at the workflow or job level so the token has only the minimal capabilities required. For this workflow, the job reads the repository (checkout) and uploads an artifact to the workflow run, but does not need to write to repository contents or other GitHub resources. Therefore, setting permissions: contents: read is sufficient.

The best minimal change is to add a permissions block at the root of .github/workflows/generate_war_file.yml, just below the name (or above jobs:). This will apply to all jobs in the workflow (currently just build) and restrict the GITHUB_TOKEN to read-only access to repository contents. No other code or steps need to change, and no additional imports or methods are required.

Concretely, in .github/workflows/generate_war_file.yml, insert:

permissions:
  contents: read

after the name: 'Generate dataverse war file' line (line 1 in the snippet). All existing steps remain unchanged.

Suggested changeset 1
.github/workflows/generate_war_file.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/generate_war_file.yml b/.github/workflows/generate_war_file.yml
--- a/.github/workflows/generate_war_file.yml
+++ b/.github/workflows/generate_war_file.yml
@@ -1,5 +1,8 @@
 name: 'Generate dataverse war file'
 
+permissions:
+  contents: read
+
 on:
   workflow_dispatch:
     inputs:
EOF
@@ -1,5 +1,8 @@
name: 'Generate dataverse war file'

permissions:
contents: read

on:
workflow_dispatch:
inputs:
Copilot is powered by AI and may make mistakes. Always verify output.
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:develop
ghcr.io/gdcc/configbaker:develop

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin
Copy link
Member Author

pdurbin commented Mar 19, 2026

@pdurbin pdurbin merged commit 270032e into master Mar 19, 2026
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged 🚀

Development

Successfully merging this pull request may close these issues.

9 participants