-
Notifications
You must be signed in to change notification settings - Fork 538
Merge "develop" into "master" for 6.10 release #12233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+19,214
−3,030
Merged
Changes from all commits
Commits
Show all changes
937 commits
Select commit
Hold shift + click to select a range
636e7cc
fix parsing after some change.
qqmyers 527f07a
remove this Payaya file until we have scripts like Solr
pdurbin a809c76
Update doc/sphinx-guides/source/developers/dev-environment.rst
qqmyers ad22235
adding signed param to GET endpoints
stevenwinship 2c5985d
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 7d40f95
Merge pull request #11983 from GlobalDataverseCommunityConsortium/GDC…
sekmiller cedd4c2
add overwrite to name, email, institution, and position in guestbook …
stevenwinship 917b3fa
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship dc9f8bc
fix doc
stevenwinship a1bca73
Merge branch 'develop' into 11747-review-dataset-type
pdurbin d6aa29a
fix doc
stevenwinship 455759e
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin 72fce96
add email validation
stevenwinship cf2937b
add email validation
stevenwinship 37b0bdd
Handle duplicate role assignments with 409 Conflict instead of 403 Fo…
vera e3ff029
Defaulting to HTTP/1 for OAI calls.
landreev f4e140e
Increasing the timeout; an extra comment about HTTP/1 vs. 2. #11473
landreev 1126df8
A config guide entry and a release note. #11473
landreev 2e093e9
typos #11473
landreev 5c73026
Fix for Cache Test (#12172)
qqmyers 2c6d86d
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship a041aa9
Merge branch 'develop' into 11473-harvesting-client-ratelimit
landreev f5b77ea
fix role assign, add logging for revoke debugging
qqmyers aae1cbd
fix for revoke
qqmyers 28a4a48
typo
landreev 4a2578d
Merge branch '11473-harvesting-client-ratelimit' of https://github.co…
landreev dac0202
duplicated code rearranged; an extra comment #11473
landreev 24dedde
fixing broken tests when dup role assingment changed to return 409 (#…
stevenwinship a9985d3
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship dff0d9e
Merge branch 'develop' into 11473-harvesting-client-ratelimit
stevenwinship ed96e7a
Bump actions/upload-artifact from 6 to 7
dependabot[bot] 4f9a878
Bump actions/download-artifact from 6 to 8
dependabot[bot] 912317f
Fixes the handling of the default behavior, with no setting present. …
landreev 7bfd5ef
Update Dataverse module GitHub link
Parthsuii 5230722
fix: fix bug in notifications API related to SUBMITTEDDS notification…
vera 592a352
Merge branch 'develop' into patch-1
Parthsuii 0d165f6
Merge pull request #12187 from Parthsuii/patch-1
pdurbin 657320b
make Payara 7 upgrade instructions much more detailed #12020
pdurbin f5f470e
comment out jsp servlet mappings
pdurbin a0ffae9
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 66997f7
Merge branch 'develop' into 11473-harvesting-client-ratelimit
stevenwinship 7aa4f1a
add unit test
stevenwinship 07e05ab
upgrade from Payara 7.2026.1 to .2 and other tweaks #12020
pdurbin 2b996dc
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin 6b7284d
Update doc/release-notes/11473-harvesting-client-improvements.md
landreev 1992849
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 525a6f7
remove Java version from Temurin link and text #11585
pdurbin ab99c33
revert to correct version of postgres (17)
pdurbin be7f26a
fix formatting
pdurbin c3b4de6
let VS Code generate hashCode and equals
pdurbin b0b9b13
add test for empty string passed to allowedDatasetTypes
pdurbin cc5b11d
populate displayname with name but capitalize it
pdurbin ce4a48f
typo
pdurbin f09c27c
refactor croissant and add "slim" version #12123
pdurbin 4e986a3
put the slim version of Croissant in the "head" of the HTML #12123
pdurbin f7e176a
add croissantSlim to list of expected export formats #12123
pdurbin 4aaf954
add docs and release note for slim version of Croissant #12123
pdurbin be670d4
allow regular and review datasets the same collection #11747
pdurbin fe0c62f
Merge pull request #12081 from GlobalDataverseCommunityConsortium/DAN…
landreev 8f2ad13
remove note as we are using linkedMetadataBlocks now #11747
pdurbin 946a7e5
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin 122736c
Merge pull request #11486 from IQSS/11473-harvesting-client-ratelimit
sekmiller 35c2f75
allow guest to download with signedUrl
stevenwinship 762642d
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship c9831ad
remove signed= from docs
stevenwinship 32adb99
improve "add dataset type" docs #11747
pdurbin ac68178
Bump docker/setup-qemu-action from 3 to 4
dependabot[bot] 8650b25
Merge remote-tracking branch 'IQSS/develop' into
qqmyers de73ae1
fix OLE
qqmyers 6968009
return updated version
qqmyers 7d8714a
restore export time method lost in merge
qqmyers 988e316
Apply suggestions from code review
pdurbin ddf3040
merge issue - if requireEarlierVersions fails, return false
qqmyers 6279e4f
tweak docs
pdurbin 9b5d4eb
add comment about non-use of PeerReview #11747
pdurbin f561a07
Merge branch 'develop' into 11747-review-dataset-type
pdurbin bdfccc9
fix require earlier versions logic
qqmyers bc06e3b
fix getting file ids from csv
stevenwinship 8b01d05
Merge pull request #12042 from IQSS/dependabot/github_actions/actions…
pdurbin 1c976e6
Merge pull request #12125 from IQSS/dependabot/github_actions/applebo…
pdurbin f4134b0
Merge pull request #12185 from IQSS/dependabot/github_actions/actions…
pdurbin 17df493
Merge pull request #12186 from IQSS/dependabot/github_actions/actions…
pdurbin 23fbc54
Merge pull request #12193 from IQSS/dependabot/github_actions/docker/…
pdurbin e818850
Handle additional line sep chars for DD-2210
qqmyers 9c4e398
clean up test code
pdurbin 050439d
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 2b03a64
better handling of collections disallowing "dataset" datasetType #121…
pdurbin 38ec9a7
move "create collection" step down, just before "allow type" #11747
pdurbin d988622
Merge pull request #12191 from IQSS/12123-croissant-slim
landreev bebb87b
add sample file dataset-create-review.json #11747
pdurbin 169aa00
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 0f8bd28
fixing questbook response handling
stevenwinship 60371d0
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship f66fa60
add test for required fields in a metadata block tsv #11747
pdurbin 92c95e6
link dataset type properly in test (fix typo) #11747
pdurbin 6ce900b
Bump org.keycloak:keycloak-services in /conf/keycloak/builtin-users-spi
dependabot[bot] 2bbb9b5
Bump docker/login-action from 3 to 4
dependabot[bot] dc6d740
lock in workflow again
qqmyers ad9fa5d
fix async/new txtn for updatelastIndex
qqmyers 84676fc
don't merge in export all
qqmyers 5274098
stop wf from overwriting timestamps
qqmyers 366396e
add updating index, permindex, export times
qqmyers b561811
Add DATASETMENTIONED status to user administration guide
Parthsuii fc0f003
add check for downloading thumbnails
stevenwinship 726603f
add check for downloading thumbnails
stevenwinship 9176f57
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin 19cfb84
Merge pull request #12197 from IQSS/dependabot/maven/conf/keycloak/bu…
pdurbin 2afc7bf
Merge pull request #12198 from IQSS/dependabot/github_actions/docker/…
pdurbin 5982c56
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 00962b0
Update doc/sphinx-guides/source/api/native-api.rst
stevenwinship 179d0ea
update docs
stevenwinship 8e63f15
Update src/main/java/edu/harvard/iq/dataverse/util/UrlSignerUtil.java
stevenwinship faefe7f
update docs
stevenwinship 90fd76d
add created sttaus checks to IT tests
stevenwinship efef793
create guestbook returns ok
stevenwinship f215ba6
Merge branch 'develop' into 11747-review-dataset-type
pdurbin f320a39
update docs
stevenwinship 943875c
make itemReviewedCitation required #11747
pdurbin 4d71ae2
link to linkedMetadataBlocks required in tsv issue
pdurbin 135542f
remove prettyPrints
stevenwinship 42f9fcf
remove print statements
stevenwinship 4da6d9f
better citation for item reviewed
pdurbin 39fb5f6
Merge pull request #11753 from IQSS/11747-review-dataset-type
scolapasta 50acabb
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin cf13f59
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 845e196
link to /api/linkeddatanotification #11864
pdurbin b8e629e
Merge pull request #12199 from Parthsuii/patch-2
pdurbin 910848a
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 9824b62
Merge pull request #12167 from GlobalDataverseCommunityConsortium/DAN…
sekmiller 639f4c9
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
pdurbin 162a40f
add fix to access request test
stevenwinship 561f24b
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship d045f1a
document require-embargo-reason feature flag #12067
pdurbin 0c01e22
Merge pull request #12202 from IQSS/12067-docs-for-require-embargo-re…
pdurbin c095efc
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 485bd01
Revert "DANS QDR Merged ORE/Bag changes for QA"
sekmiller 37aeff2
Remove Google doc link for metadata tips access
Parthsuii 8db3dd2
Merge pull request #12203 from IQSS/revert-12167-DANS-QDR-merged_bag_…
sekmiller b4fe522
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship f1846a2
Remove tips for submitting issues and PRs from metadata doc
Parthsuii cbd6381
Update metadatacustomization.rst
Parthsuii 9744886
explain :DatasetPublishPopupCustomText vs :PublishDatasetDisclaimerTe…
pdurbin 2eb686c
add more links #12051 (#12207)
pdurbin 15695c7
flag review datasets as experimental #11753 (#12209)
pdurbin 29e8fab
Bump webfactory/ssh-agent from 0.9.1 to 0.10.0
dependabot[bot] c8d74ca
careful
pdurbin 4234b99
Apply suggestion from @landreev
pdurbin 87ffbaa
Apply suggestion from @landreev
pdurbin 7e5b553
Apply suggestion from @landreev
pdurbin 791f617
Apply suggestion from @landreev
pdurbin 2c5fd3c
Revert "Revert "DANS QDR Merged ORE/Bag changes for QA""
qqmyers 329b167
small tweaks and fix step numbering
pdurbin 8b198d1
move hashtype check inside loop, remove unused ignorehashes
qqmyers d1660b9
restore dataverse functionality
qqmyers ed0b1e9
keep domain.xml editing together
pdurbin 05c503e
copy over sitemap
pdurbin 3642eda
Merge pull request #12210 from IQSS/dependabot/github_actions/webfact…
pdurbin bf72357
Add contribution tips for metadata customization guide
Parthsuii 316fbb3
Merge pull request #12204 from Parthsuii/patch-3
pdurbin 1addebd
adding check for missing 'answers' block in guestbook response
stevenwinship 544fdcf
Merge remote-tracking branch 'IQSS/develop' into DANS_QDR_3
qqmyers f6d5e8d
adding test for access request with gustbook response required but gu…
stevenwinship 98e4820
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship ac3fd32
fix signedurl with persistentId to replace it database id
stevenwinship 8e8966d
another empty answers unit test
stevenwinship 89cf927
Merge pull request #12213 from GlobalDataverseCommunityConsortium/DAN…
sekmiller 7c47505
add word
pdurbin 30be73c
typo
pdurbin 0c7d3a6
Merge branch 'develop' into 12001-api-support-termofuse-guestbook
stevenwinship 2d7bd80
Merge remote-tracking branch 'IQSS/develop' into IQSS/12020-Payara7_J…
qqmyers 149ebde
fix typo guestbook_id to guestbookId in json
stevenwinship 05a961e
adding to docs
stevenwinship 879c465
give downloaders more hints to find the guestbookId #12001
pdurbin 35a1eb2
add guestbookId to missing response message
stevenwinship b96efcf
Merge branch '12001-api-support-termofuse-guestbook' of https://githu…
stevenwinship d9b59ca
doc change
stevenwinship 63db903
add guestbookId to request access error message
stevenwinship 459af37
remove redundant commands
pdurbin 3163b52
Bump marocchino/sticky-pull-request-comment from 2 to 3
dependabot[bot] ee079f1
Merge pull request #12217 from IQSS/dependabot/github_actions/marocch…
pdurbin 05f9b92
change create guestbook from returning 200 to 201
stevenwinship 173b1be
Merge pull request #12110 from IQSS/12001-api-support-termofuse-guest…
sekmiller 9cdcb63
Merge branch 'develop' into IQSS/12020-Payara7_Java21_update
qqmyers 18a462e
Merge pull request #12043 from QualitativeDataRepository/IQSS/12020-P…
landreev 5205954
resolve merge conflicts in Guestbook.java
pdurbin d55acc6
Merge pull request #12219 from IQSS/12043-gb-conflicts
pdurbin 36ab0c4
stub out 6.10 release notes #12085
pdurbin 1fb88c3
croissant built in
pdurbin 34a6797
review datasets
pdurbin c2b670b
dataverse-uploader github-action fixed
pdurbin 0f954ed
breadcrumbs
pdurbin cc995bd
solr reindex deleted
pdurbin f32f1be
remove extra line
pdurbin 467982f
locks info
pdurbin 65daf36
DATASETMOVED notification
pdurbin 3ebcd97
mydata params
pdurbin 23f9005
handle redirect
pdurbin 40565fe
replace file
pdurbin dd712ba
bearer token
pdurbin 3d1c80e
stored proc
pdurbin 77bb684
index perf
pdurbin 5bb915c
proto header
pdurbin c1c7cb4
embargo reason
pdurbin ca2349a
assign role
pdurbin 5cb200f
ignoreSettingExcludeEmailFromExport
pdurbin 62480e2
harvest sleep
pdurbin a7fdd36
coar
pdurbin 9baa523
refi
pdurbin 146fc1a
archival status
pdurbin 910142f
hide oidc from JSF
pdurbin a764057
rdm-int
pdurbin b77e0b9
refi
pdurbin 5a35f2a
disclaimer
pdurbin 6471790
templates
pdurbin 1247390
reorg highlights
pdurbin f463777
no particular developer updates
pdurbin 419d1f2
add upgrade instructions
pdurbin ac097c8
flag review datasets as experimental
pdurbin 4c175a2
archiving
pdurbin c78e1c2
typos and cleanup #12085
pdurbin e5ca6e4
hidden fields bug fixed, add to release notes #11992 #12017 #12085
pdurbin 5516947
guestbook response can be required for file download
pdurbin dd642d0
upgrade to Payara 7 and Java 21
pdurbin 75f7ef7
Update 6.10-release-notes.md
doigl 72ae455
mention guestbook API
pdurbin 6a5b3cd
Merge pull request #12222 from doigl/patch-2
pdurbin 07a21f5
switch back to US acknowledgment
pdurbin 5d95b8f
Update doc/release-notes/6.10-release-notes.md
pdurbin 570b706
fix numbering
pdurbin e851566
A deployment workflow for dataverse-internal.iq.dataverse.edu; largel…
landreev 1e238ad
Update doc/release-notes/6.10-release-notes.md
pdurbin dcff397
Update doc/release-notes/6.10-release-notes.md
pdurbin f3215a9
pgdg13 workaround
pdurbin e9610de
removing an offending line from the workflow
landreev 67d7028
and one more fix
landreev 7639a3a
adding workflow_dispatch
landreev 5ef6665
an experiment
landreev acaabde
an experiment
landreev 04a63db
warfile-building workflow, with an optional build number label
landreev ec01449
assorted fixes; makes it possible to add arbitrary labels to the vers…
landreev df15374
Potential fix for code scanning alert no. 369: Use of a known vulnera…
landreev 1703f21
Potential fix for code scanning alert no. 371: Workflow does not cont…
landreev 0c5ef01
fixing, or hiding the test error.
landreev 8ed62f6
Merge branch 'extra_workflows' of https://github.com/IQSS/dataverse i…
landreev cb48a82
Merge pull request #12226 from IQSS/extra_workflows
landreev ccd056c
fixing some remaining issues.
landreev dda0fce
Merge pull request #12227 from IQSS/extra_workflows
pdurbin 3914474
Merge pull request #12208 from IQSS/12085-6.10-release-notes
scolapasta 3fc1382
bump to version 6.10 #12091
pdurbin 326aa5e
Merge pull request #12230 from IQSS/12091-bump-to-6.10
pdurbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: 'Deploy to dataverse-internal.iq.harvard.edu' | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| buildlabel: | ||
| description: 'Custom label that will appear after the version number (the equivalent of the old "build number" entry). Leaving it empty will default to the legacy behavior, i.e. " build <branch>-<checksum>".' | ||
| type: string | ||
| required: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: deploy-to-internal | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '21' | ||
|
|
||
| - name: Set build number | ||
| run: scripts/installer/custom-build-number "${{ github.event.inputs.buildlabel }}" | ||
|
|
||
| - name: Build application war | ||
| run: mvn package | ||
|
|
||
| - name: Get war file name | ||
| working-directory: target | ||
| run: echo "war_file=$(ls *.war | head -1)">> $GITHUB_ENV | ||
|
|
||
| - name: Upload war artifact | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: built-app | ||
| path: ./target/${{ env.war_file }} | ||
|
|
||
| deploy-to-payara: | ||
| needs: build | ||
| if: ${{ github.repository_owner == 'IQSS' }} | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Download war artifact | ||
| uses: actions/download-artifact@v8 | ||
| with: | ||
| name: built-app | ||
| path: ./ | ||
|
|
||
| - name: Get war file name | ||
| run: echo "war_file=$(ls *.war | head -1)">> $GITHUB_ENV | ||
|
|
||
| - name: Copy war file to remote instance | ||
| uses: appleboy/scp-action@master | ||
| with: | ||
| host: ${{ secrets.INTERNAL_PAYARA_INSTANCE_HOST }} | ||
| username: ${{ secrets.INTERNAL_PAYARA_INSTANCE_USERNAME }} | ||
| key: ${{ secrets.INTERNAL_PAYARA_INSTANCE_SSH_PRIVATE_KEY }} | ||
| source: './${{ env.war_file }}' | ||
| target: '/home/${{ secrets.INTERNAL_PAYARA_INSTANCE_USERNAME }}' | ||
| overwrite: true | ||
|
|
||
| - name: Execute payara war deployment remotely | ||
| uses: appleboy/ssh-action@v1.2.5 | ||
| env: | ||
| INPUT_WAR_FILE: ${{ env.war_file }} | ||
| with: | ||
| host: ${{ secrets.INTERNAL_PAYARA_INSTANCE_HOST }} | ||
| username: ${{ secrets.INTERNAL_PAYARA_INSTANCE_USERNAME }} | ||
| key: ${{ secrets.INTERNAL_PAYARA_INSTANCE_SSH_PRIVATE_KEY }} | ||
| envs: INPUT_WAR_FILE | ||
| script: | | ||
| APPLICATION_NAME=dataverse-backend | ||
| ASADMIN='/usr/local/payara7/bin/asadmin --user admin' | ||
| $ASADMIN undeploy $APPLICATION_NAME | ||
| #$ASADMIN stop-domain | ||
| #$ASADMIN start-domain | ||
| $ASADMIN deploy --name $APPLICATION_NAME $INPUT_WAR_FILE | ||
| #$ASADMIN stop-domain | ||
| #$ASADMIN start-domain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: 'Generate dataverse war file' | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| buildlabel: | ||
| description: 'Custom label that will appear after the version number (the equivalent of the old "build number" entry). Leaving it empty will default to the legacy behavior, i.e. " build <branch>-<checksum>".' | ||
| type: string | ||
| required: false | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '21' | ||
|
|
||
| - name: Set build number | ||
| run: scripts/installer/custom-build-number "${{ github.event.inputs.buildlabel }}" | ||
|
|
||
| - name: Build application war | ||
| run: mvn package | ||
|
|
||
| - name: Get war file name | ||
| working-directory: target | ||
| run: echo "war_file=$(ls *.war | head -1)">> $GITHUB_ENV | ||
|
|
||
| - name: Upload war artifact | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: built-app | ||
| path: ./target/${{ env.war_file }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI about 11 hours ago
In general, the fix is to explicitly define GITHUB_TOKEN permissions at the workflow or job level so the token has only the minimal capabilities required. For this workflow, the job reads the repository (checkout) and uploads an artifact to the workflow run, but does not need to write to repository contents or other GitHub resources. Therefore, setting
permissions: contents: readis sufficient.The best minimal change is to add a
permissionsblock at the root of.github/workflows/generate_war_file.yml, just below thename(or abovejobs:). This will apply to all jobs in the workflow (currently justbuild) and restrict the GITHUB_TOKEN to read-only access to repository contents. No other code or steps need to change, and no additional imports or methods are required.Concretely, in
.github/workflows/generate_war_file.yml, insert:after the
name: 'Generate dataverse war file'line (line 1 in the snippet). All existing steps remain unchanged.