Skip to content

feat(treegrid-esf): tree filter view #10871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 91 commits into from
Feb 28, 2022
Merged

feat(treegrid-esf): tree filter view #10871

merged 91 commits into from
Feb 28, 2022

Conversation

@igdmdimitrov
Copy link
Contributor

@igdmdimitrov igdmdimitrov commented Jan 20, 2022 •
edited by DiyanDimitrov
Loading

Closes #10342
Closes #11004

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@igdmdimitrov igdmdimitrov added 🛠️ status: in-development Issues and PRs with active development on them ❌ do not merge labels Jan 20, 2022
@igdmdimitrov igdmdimitrov marked this pull request as ready for review February 10, 2022 09:34
simeonoff and others added 9 commits February 10, 2022 16:40
@DiyanDimitrov
Copy link
Contributor

DiyanDimitrov commented Feb 24, 2022

@rkaraivanov @dkamburov The PR is now ready for a review. I am still wondering whether we should deprecate the uniqueColumnValuesStrategy property in favor of the new getFilterItems method of the filtering strategy or leave them both. Let me know what you think.

@onlyexeption onlyexeption added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 25, 2022
@igdmdimitrov igdmdimitrov changed the title feat(esf): hierarchical search in excel style filtering feat(treegrid-esf): tree filter view Feb 25, 2022
@onlyexeption onlyexeption added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 25, 2022
@ChronosSF ChronosSF merged commit f562698 into master Feb 28, 2022
@ChronosSF ChronosSF deleted the dmdimitrov/tree-grid-esf-search branch February 28, 2022 08:07
randriova added a commit that referenced this pull request Sep 29, 2022
@randriova
fix(i18n): Updating localization for #10147, #10736, #10871, #10996, #…
ad8b89c 
…11923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkamburov dkamburov dkamburov approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

@DiyanDimitrov DiyanDimitrov Awaiting requested review from DiyanDimitrov

Assignees

@onlyexeption onlyexeption

Labels

filtering grid: excel-style-filtering status: localized version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grid filter strategy refactoring igx-tree-grid: excel-style filtering should show children of parent elements returned from the filter