Skip to content

Conversation

@MayaKirova
Copy link
Contributor

Closes #10977

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev mddragnev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 14, 2022
@mddragnev
Copy link
Member

@MayaKirova
When initially starting the dev sample an error is thrown with ExpressionChangedAfterItHasBeenCheckedError exception.
image

Also, when you open the grid and remove one by one every column and row dimension it makes them disabled but not entirely removing them from the configuration. In this case the message "Pivot grid has no dimensions and values defined" should not show.
Steps to reproduce:

  1. Open pivot dev sample
  2. Remove all dimensions from the chips

ChronosSF
ChronosSF previously approved these changes Feb 14, 2022
@MayaKirova
Copy link
Contributor Author

The empty message has been updated to also be applicable when dimensions/values are disabled.

@mddragnev The error seems to originate from master, it does not seem related to templates.

@dkamburov dkamburov requested a review from ChronosSF February 15, 2022 15:02
@mddragnev mddragnev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 16, 2022
@MayaKirova MayaKirova requested a review from mddragnev February 17, 2022 09:56
@ChronosSF ChronosSF merged commit 0cd5bbe into master Feb 17, 2022
@ChronosSF ChronosSF deleted the mkirova/pivot-empty-template branch February 17, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: pivot status: localized ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pivot] Implement empty template for empty pivot configuration

6 participants