fix(tree): render deferred selection in zoneless apps#17449
Open
viktorkombov wants to merge 1 commit into
Open
fix(tree): render deferred selection in zoneless apps#17449viktorkombov wants to merge 1 commit into
viktorkombov wants to merge 1 commit into
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes IgxTree checkbox rendering in zoneless Angular apps when selection is applied via the deferred forceSelect path (e.g., initial [selected] bindings and cascading updates after node removal).
Changes:
- Injects
ChangeDetectorRefinIgxTreeComponentand callsmarkForCheck()after deferred selection is applied. - Adds zoneless unit tests covering (1) initial selected node rendering and (2) cascading selection update after removing an unselected child node.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/tree/src/tree/tree.component.ts | Triggers change detection scheduling after applying deferred selection to keep checkbox UI in sync in zoneless apps. |
| projects/igniteui-angular/tree/src/tree/tree-selection.spec.ts | Adds zoneless regression tests for initial selection rendering and cascading selection after node deletion. |
mddragnev
added
✅ status: verified
Member
|
The issue is fixed indeed. However, I see another issue. If you later show the second |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17444
Description
Fixes Tree checkbox states not updating after deferred selection changes in
zoneless applications.
Covers initial selection and cascading selection after removing a child node.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)