Skip to content

docs(Grid): Fix missing @param in sassdocs and remove unnecessary properties in the light schema #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lipata merged 8 commits into from
Aug 5, 2019
Merged

docs(Grid): Fix missing @param in sassdocs and remove unnecessary properties in the light schema #5526

Lipata merged 8 commits into from
Aug 5, 2019

Conversation

@desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jul 29, 2019 •
edited
Loading

Closes #5432

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested review from kdinev and simeonoff July 29, 2019 07:26
@desig9stein desig9stein changed the title docs(Grid): Fix missing @param in docs and remove unnecessary properties in the light schema docs(Grid): Fix missing @param in sassdocs and remove unnecessary properties in the light schema Jul 29, 2019
@mmart1n mmart1n added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 29, 2019
simeonoff
simeonoff previously approved these changes Jul 29, 2019
View reviewed changes
@mmart1n mmart1n added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jul 29, 2019
@desig9stein desig9stein reopened this Jul 30, 2019
@desig9stein desig9stein changed the base branch from master to 8.1.x July 30, 2019 07:16
@desig9stein desig9stein requested a review from simeonoff July 30, 2019 07:17
@mmart1n mmart1n added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 30, 2019
@Lipata Lipata merged commit 7984775 into 8.1.x Aug 5, 2019
@Lipata Lipata deleted the fix-for-5432-master branch August 5, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@mmart1n mmart1n

Labels

grid: general sassdoc version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@desig9stein @simeonoff @Lipata @mmart1n @kdinev