feat(TwoFactorAuth): Handle errors and retries, and update translations #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisCAD
force-pushed
the
two-factor-auth
branch
from
0894cf2 to
c531904
Compare
LouisCAD
force-pushed
the
errors-and-retries
branch
from
506f255 to
e86c96b
Compare
LouisCAD
force-pushed
the
two-factor-auth
branch
from
c531904 to
e26b630
Compare
LouisCAD
force-pushed
the
errors-and-retries
branch
from
e86c96b to
6b53f76
Compare
LouisCAD
force-pushed
the
two-factor-auth
branch
from
e26b630 to
d651796
Compare
LouisCAD
force-pushed
the
errors-and-retries
branch
from
80cf6a5 to
b238687
Compare
FabianDevel
requested changes
Oct 14, 2025
TwoFactorAuth/Front/src/main/kotlin/ConfirmLoginBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
FabianDevel
approved these changes
Oct 16, 2025
|
This PR/issue depends on:
|
This ensures the different states have the same alignment.
They're not used outside, the public ones should be good enough for our use case(s).
…er as a top-level function
… improve KDoc + comments
KevinBoulongne
force-pushed
the
protected/feat-2fa
branch
from
5489a02 to
ae69fc3
Compare
KevinBoulongne
force-pushed
the
errors-and-retries
branch
from
808af51 to
928934c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, the icons will be updated to support dark/light theming.Depends on #509