Broken lighting when using WorldEdit operations.

[mibby]

Bug report for FastAsyncWorldEdit 1.15.2

[REQUIRED] FastAsyncWorldEdit Configuration Files:
config: https://paste.ubuntu.com/p/9hDB8hdgSM/
config-legacy: https://paste.ubuntu.com/p/MkQDTRFwNw/

[REQUIRED] FastAsyncWorldEdit Version Number:
FastAsyncWorldEdit dev 217

[REQUIRED] Spigot/Paper Version Number:
Paper dev 273 (Spigot 1.15.2)

[REQUIRED] Description of the problem:
Chunk relighting is broken when doing worldedit operations.

How to replicate:

• Make a 2 point selection.
• //replace air

Also tested with these changes.

lighting:
  # If packet sending should be delayed until relight is finished
  delay-packet-sending: true
  async: true
  # The relighting mode to use:
  #  - 0 = None (Do no relighting)
  #  - 1 = Optimal (Relight changed light sources and changed blocks)
  #  - 2 = All (Slowly relight every blocks)
  mode: 1
  # If existing lighting should be removed before relighting
  remove-first: false

lighting:
  # If packet sending should be delayed until relight is finished
  delay-packet-sending: false
  async: true
  # The relighting mode to use:
  #  - 0 = None (Do no relighting)
  #  - 1 = Optimal (Relight changed light sources and changed blocks)
  #  - 2 = All (Slowly relight every blocks)
  mode: 2
  # If existing lighting should be removed before relighting
  remove-first: true

Checklist:

• I included all information required in the sections above
• I made sure there are no duplicates of this report (Use Search)
• I made sure I am using an up-to-date version of FastAsyncWorldEdit for 1.15.2
• I made sure the bug/error is not caused by any other plugin

[aurorasmiles]

Currently not implemented in the new versions. But since apparently there is no issue open for this, or I didn't find one, I'm keeping this one open as a reminder. I think Matt was working on this :)

[aurorasmiles]

In the meantime, we suggest you use Light Cleaner (https://www.spigotmc.org/resources/light-cleaner.42469/)

SpigotMC - High Performance Minecraft

Light Cleaner

Regenerates light levels in your world, fixing bugged lighting such as black cliffs

[MattBDev]

@aurora I'll get to it. At the rate I have been going for the past 2 weeks my ETA is X amount of years. lol.
Realistically, hopefully soon.

[NanoAi]

Oddly light cleaner doesn't always work either. So really hoping this will be fixed soon.

[SecretlyJealous]

FAWE doesn't touch lighting in the newer versions but for some reason the server is actively messing with the lighting (guessing it's something to do with the light engine and some logic on chunk loading but this is exclusive to 1.14/1.15 because in 1.13 this doesn't happen).

If you do a very large cut operation on the ground you will see how some of the lighting has been updated and some of it hasn't:

After relogging the dark patches don't show up, only the corners seem to have the incorrect lighting but what's strange is that this whole area should be dark because FAWE does not deal with lighting at the moment:

In this state LightCleaner is not able to fix the lighting glitches, example:

Even after relogging I am not able to get rid of this glitch. This is something I want to test with: #475