Skip to content

Conversation

@PierreSchwang
Copy link
Member

Overview

Fixes #3414

Description

regression introduced in #3406
the special empty ops value seems to be kinda required and switching that to a compound broke several codecs. Switched it back to a EndTag and implemented the remaining mergeToMap methods. I don't really know how I got the error leading to the linked PR - I just know that some codec attempted to put the empty (LinEndTag) into a compound tag which LinBus obviously prevents and errors. I should've filtered all EndTags so they hopefully don't get put into any compounds. Couldn't get the error to reproduce on my original testing server at least.

And the test cases from the issue do work as well.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@PierreSchwang PierreSchwang requested a review from a team as a code owner December 26, 2025 18:21
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Dec 26, 2025
@Stoupy51
Copy link

Fix tested and working right! Lovely thank you

image

@DoogiePC
Copy link

DoogiePC commented Dec 27, 2025

The commit doesn't work with any coloured signs
image

@PierreSchwang
Copy link
Member Author

The commit doesn't work with any coloured signs image

How did you create the sign? I can't reproduce that with a sign that I right-clicked with blue dye and a glow ink sac

@DoogiePC
Copy link

The commit doesn't work with any coloured signs image

How did you create the sign? I can't reproduce that with a sign that I right-clicked with blue dye and a glow ink sac

Just the usual way of &atest
normal Minecraft colour codes

@PierreSchwang
Copy link
Member Author

PierreSchwang commented Dec 27, 2025

those are not "normal" color codes nor is that possible without other plugins. share the /data get block <x> <y> <z> output for the colored sign got it

@DoogiePC
Copy link

/data get block

image

@PierreSchwang
Copy link
Member Author

should be fixed now

@PierreSchwang PierreSchwang merged commit de6f93e into main Dec 28, 2025
11 checks passed
@PierreSchwang PierreSchwang deleted the fix/linOpsNbt branch December 28, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy writes broken NBT that can't be read

5 participants