Skip to content

Conversation

@dordsor21
Copy link
Member

@dordsor21 dordsor21 commented Aug 24, 2025

@dordsor21 dordsor21 requested a review from a team as a code owner August 24, 2025 16:26
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Aug 24, 2025
@NotMyFault NotMyFault requested a review from Copilot August 26, 2025 15:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses unnecessary flight status changes when players exit plots by modifying the plotExit method to consider the destination plot's flight settings before disabling flight. The changes prevent flight from being unnecessarily disabled when moving between plots that both allow flight.

  • Added nextPlot and nextArea parameters to the plotExit method to provide context about the destination
  • Updated flight logic to check destination flight settings before disabling flight
  • Updated all callers of plotExit to pass the new parameters

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Plot.java Updated plotExit calls to pass additional parameters for destination context
PlotListener.java Modified plotExit method signature and added logic to check destination flight settings
PlayerEventListener.java Updated plotExit calls to include destination plot/area information

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@NotMyFault NotMyFault requested a review from a team August 26, 2025 18:38
dordsor21 and others added 2 commits November 30, 2025 19:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dordsor21 dordsor21 force-pushed the fix/v7/unnecessary-flight-status-change branch from 75b2665 to 510150a Compare November 30, 2025 19:53
@NotMyFault NotMyFault merged commit b4483ef into main Dec 20, 2025
10 checks passed
@NotMyFault NotMyFault deleted the fix/v7/unnecessary-flight-status-change branch December 20, 2025 21:53
pull bot pushed a commit to Craftstuebchen/PlotSquared that referenced this pull request Dec 21, 2025
…alSites#4744)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep up flight status on plot exit

4 participants