fix: gate Azure Monitor profiler on supported platforms - #1265
Merged
Conversation
Add a platform check before registering the Azure Monitor profiler so the app can start on macOS. Also add a lightweight macOS GitHub Actions workflow that restores, builds, and tests the solution to catch future platform regressions.
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…-mac-startup # Conflicts: # EssentialCSharp.Web/Program.cs Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Contributor
Merge conflicts resolved in commit 8a10285. The conflict in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS startup currently fails because the Azure Monitor profiler is registered unconditionally even though that component only supports Windows and Linux. This change keeps Azure Monitor export enabled cross-platform while avoiding profiler registration on unsupported platforms.
It also adds a small macOS GitHub Actions smoke workflow so restore, build, and test run on
macos-latestfor pull requests and merge groups. That gives us lightweight platform coverage for this class of regression without changing the existing Ubuntu-focused CI path.What changed
AddAzureMonitorProfiler()behind a Windows/Linux platform checkNotes
/p:AccessToNugetFeed=falseto match the repo's public CI behavior