Skip to content

Fix Build Failure #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 27, 2022
Merged

Fix Build Failure #316

merged 13 commits into from
Jul 27, 2022

Conversation

@BenjaminMichaelis
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis commented Jul 26, 2022 •
edited
Loading

fixes #312

@BenjaminMichaelis BenjaminMichaelis changed the title update sdk action to v2 Fix Build Failure Jul 26, 2022
@BenjaminMichaelis
Copy link
Member Author

BenjaminMichaelis commented Jul 26, 2022

Updating checkout to v3 and setup dotnet to v2

@BenjaminMichaelis
Minor fix
2944bb3 
Minor fix


Minor fix


Minor Fix


Minor Fix


Fix path


Fix Path
@BenjaminMichaelis
Cleanup file
74d3fc3
@BenjaminMichaelis
Copy link
Member Author

BenjaminMichaelis commented Jul 27, 2022 •
edited
Loading

After adding the props file in, it caused the ubuntu and windows builds to fail which is interesting since that means adding in a props file fails on dotnet 5 (the build is here: https://github.com/IntelliTect/EssentialCSharp/runs/7532253715?check_suite_focus=true) but after adding in a global.json and installing the dotnet 6 sdk onto the machine, then it passes for all builds. (https://github.com/IntelliTect/EssentialCSharp/runs/7532292828?check_suite_focus=true).

@BenjaminMichaelis BenjaminMichaelis requested a review from Keboo July 27, 2022 02:11
Keboo
Keboo reviewed Jul 27, 2022
View reviewed changes
@BenjaminMichaelis
Copy link
Member Author

BenjaminMichaelis commented Jul 27, 2022

So currently we do need a global.json because we ended up with failures on dotnet 5 of "warningCS8632:Theannotationfornullablereferencetypesshouldonlybeusedincodewithina'#nullable'annotationscontext.". I have a suspicion this is because with the directory props file being empty, when the csproj file is being generated, it by default has nullability disabled. I am testing this theory by adding it to be enabled in the pwsh script here: #318 . If it passes, I will get to drop the globl.json in this pr and just instead add nullability to the pwsh script for the props file.

@BenjaminMichaelis BenjaminMichaelis requested a review from Keboo July 27, 2022 16:09
@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) July 27, 2022 16:10
Keboo
Keboo reviewed Jul 27, 2022
View reviewed changes
@BenjaminMichaelis BenjaminMichaelis requested a review from Keboo July 27, 2022 16:35
@BenjaminMichaelis BenjaminMichaelis merged commit 80e7be7 into v9.0 Jul 27, 2022
@BenjaminMichaelis BenjaminMichaelis deleted the testupdatingdotnetsdks branch July 27, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keboo Keboo Keboo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate why build failure is occurring only on mac

3 participants

@BenjaminMichaelis @Keboo