Skip to content

Update dependencies and fix issues in version 0.1.8#267

Merged
ehsan-fj merged 17 commits intomainfrom
develop
Mar 11, 2026
Merged

Update dependencies and fix issues in version 0.1.8#267
ehsan-fj merged 17 commits intomainfrom
develop

Conversation

@ehsan-fj
Copy link
Copy Markdown
Member

This pull request refines how passwords are handled for EPP contact and domain operations, ensuring that passwords are only auto-generated when required and not unnecessarily included in updates. It also improves robustness when handling missing data and updates test coverage accordingly. Additionally, the PR updates some dependencies and fixes a template naming typo.

Password handling improvements:

  • Passwords are now auto-generated only during Contact.create() and Domain.create() if not supplied, and are no longer generated or included by default in update operations or in the base command logic. This prevents sending unnecessary passwords and aligns behavior with EPP best practices. [1] [2] [3]
  • The command template for contacts now conditionally includes the <contact:authInfo> block only if a password is provided, preventing empty password fields in generated XML.

Robustness and bug fixes:

  • The _data_to_dict method in Contact now safely handles cases where postal_info is None, preventing AttributeError and ensuring correct dictionary output.
  • The Contact.update() method checks for the existence of postal_info before accessing its attributes, preventing errors during updates when this data is missing.

Template and import corrections:

  • Fixed a typo in the contact creation XML template variable name (CONTACT_CREAT_XMLCONTACT_CREATE_XML) and updated all usages accordingly. [1] [2] [3]
  • Removed an unused import of helper from base_command.py, and added it where needed. [1] [2] [3]

Test coverage enhancements:

  • Added and updated tests to verify that passwords are only generated for create operations, not for updates, and that missing postal_info is handled gracefully. [1] [2] [3] [4]

Dependency updates:

  • Updated several development dependencies to their latest versions for improved security and compatibility.

dependabot Bot and others added 17 commits October 6, 2025 02:05
Bumps [beautifulsoup4](https://www.crummy.com/software/BeautifulSoup/bs4/) from 4.13.5 to 4.14.2.

---
updated-dependencies:
- dependency-name: beautifulsoup4
  dependency-version: 4.14.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pylint](https://github.com/pylint-dev/pylint) from 3.3.8 to 3.3.9.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.3.8...v3.3.9)

---
updated-dependencies:
- dependency-name: pylint
  dependency-version: 3.3.9
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…-4.14.2

Bump beautifulsoup4 from 4.13.5 to 4.14.2
Bumps [lxml](https://github.com/lxml/lxml) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-6.0.1...lxml-6.0.2)

---
updated-dependencies:
- dependency-name: lxml
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pylint](https://github.com/pylint-dev/pylint) from 3.3.9 to 4.0.4.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.3.9...v4.0.4)

---
updated-dependencies:
- dependency-name: pylint
  dependency-version: 4.0.4
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [click](https://github.com/pallets/click) from 8.3.0 to 8.3.1.
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.3.0...8.3.1)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverage](https://github.com/coveragepy/coveragepy) from 7.10.7 to 7.12.0.
- [Release notes](https://github.com/coveragepy/coveragepy/releases)
- [Changelog](https://github.com/coveragepy/coveragepy/blob/main/CHANGES.rst)
- [Commits](coveragepy/coveragepy@7.10.7...7.12.0)

---
updated-dependencies:
- dependency-name: coverage
  dependency-version: 7.12.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.4.2 to 9.0.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.4.2...9.0.1)

---
updated-dependencies:
- dependency-name: pytest
  dependency-version: 9.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* only include password when supplied

Only include the password in Contact Update when supplying a password. To prevent silently overwriting the password.

* Prevent automatic password generation when not supplied in contact and domain creation; update tests accordingly

---------

Co-authored-by: Yuri Verweij <yuri.verweij@sidn.nl>
* Fix AttributeError when postal_info is None in Contact class methods

* Update test_data_to_dict_without_postal_info to assert expected result structure

---------

Co-authored-by: Yuri Verweij <yuri.verweij@sidn.nl>
Bumps [coverage](https://github.com/coveragepy/coveragepy) from 7.13.0 to 7.13.1.
- [Release notes](https://github.com/coveragepy/coveragepy/releases)
- [Changelog](https://github.com/coveragepy/coveragepy/blob/main/CHANGES.rst)
- [Commits](coveragepy/coveragepy@7.13.0...7.13.1)

---
updated-dependencies:
- dependency-name: coverage
  dependency-version: 7.13.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [beautifulsoup4](https://www.crummy.com/software/BeautifulSoup/bs4/) from 4.14.2 to 4.14.3.

---
updated-dependencies:
- dependency-name: beautifulsoup4
  dependency-version: 4.14.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pip-audit](https://github.com/pypa/pip-audit) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/pypa/pip-audit/releases)
- [Changelog](https://github.com/pypa/pip-audit/blob/main/CHANGELOG.md)
- [Commits](pypa/pip-audit@v2.9.0...v2.10.0)

---
updated-dependencies:
- dependency-name: pip-audit
  dependency-version: 2.10.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [bandit](https://github.com/PyCQA/bandit) from 1.8.6 to 1.9.2.
- [Release notes](https://github.com/PyCQA/bandit/releases)
- [Commits](PyCQA/bandit@1.8.6...1.9.2)

---
updated-dependencies:
- dependency-name: bandit
  dependency-version: 1.9.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ehsan Faraji Jalal <ehsan@internetnz.net.nz>
* Increase the version to 0.1.8

* Remove extra space in contract pw and fix a typo
@ehsan-fj ehsan-fj requested a review from levius0 March 10, 2026 20:18
@ehsan-fj ehsan-fj merged commit ba1459d into main Mar 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants