Update to Drupal 8.8.1#34
Conversation
Updated argument name in Drush policy file
Fix installer path for drush commandfiles.
drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.
This reverts commit 5085410.
This reverts commit ee5bf36.
|
@qadan brought up an issue related to pathauto and path_alias https://www.drupal.org/project/drupal/releases/8.8.0 |
|
We're not doing anything with it per se, but there may be folks out there with path auto set up and would have to be careful when upgrading. But they'd be doing that manually and not through the initial composer install, so I think it's good to move ahead with this sooner rather than later. |
|
@elizoller We don't commit the lockfile here. You would on your own project, but it messes with the installer (can't recall exactly why). Also, tests are failing but that's got nothing to do with what you're doing. Can you pull in changes from upstream to see if it fixes it? |
dannylamb
dismissed
their stale review
I meant to request changes, not approve :(
|
pull in the changes from drupal-composer/drupal-project or islandora/drupal-project? |
|
@elizoller From drupal-composer/drupal-project |
|
Nice @elizoller, tests are passing. Can you remove the lockfile and I'll merge this in? |
|
composer.lock should be deleted in this PR. although it is there in the main 8.x-1.x branch at https://github.com/Islandora/drupal-project |
|
🤦♂️ I see that now @elizoller. There was a diff... a diff that was all red... We've historically not included it, and it's not in drupal-composer/drupal-project. But history shows I accidentally committed it back in :( |
|
Sry for the confusion @elizoller. Thanks for this! |
17 participants
What does this Pull Request do?
This might be a bit bold but... I tested Drupal 8.8.1 (by updating composer packages) and it seemed to go ok, so here is my attempt at updating it the proper way.
What's new?
How should this be tested?
Point a playbook at this branch in inventory/vagrant/group_vars/webserver/drupal.yml
drupal_composer_project_package(not exactly sure how to point it to a PR instead of a release)Additional Notes:
I'm not sure if this is the right approach, but I thought I'd just put this out there to hopefully get the ball rolling.
Interested parties
@Islandora/8-x-committers