feat(enrichment): detect Knock service and Sourcegraph access tokens#3333
Closed
bohdansolovie wants to merge 2 commits into
Closed
feat(enrichment): detect Knock service and Sourcegraph access tokens#3333bohdansolovie wants to merge 2 commits into
bohdansolovie wants to merge 2 commits into
Conversation
Add high-confidence secret-scan rules for Knock knock_st_ management API service tokens and Sourcegraph sgp_ access tokens, with truncation and identifier-continuation negative tests. Co-authored-by: Cursor <cursoragent@cursor.com>
superagent-security
Bot
added
the
contributor:flagged
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
5 tasks
1 task
24 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
Contributor
Author
|
Closing to focus review capacity on #3337; Knock/Sourcegraph rules will be resubmitted after merge. |
gittensory-orb
Bot
added
the
gittensor:bug
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knock_service_tokenrule for Knockknock_st_management API service tokenssourcegraph_access_tokenrule for Sourcegraphsgp_+ 16 hex +_+ 40 hex access tokens-suffix,_suffix, alpha)Test plan
cd review-enrichment && npm run build && node --test test/secret-scan.test.ts(94 passing)Made with Cursor