fix(review): rank long-form doc extensions in diffFilePriority#3335
Conversation
GUIDE.markdown and spec.asciidoc were treated as source(0) under a tight diff budget, displacing real code. Align review-grounding and review-diff with rag.ts and path-matchers doc spellings. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 277 277
Lines 30522 30522
Branches 11114 11114
=======================================
Hits 28654 28654
Misses 1211 1211
Partials 657 657
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 03:54:03 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
diffFilePriorityinreview-grounding.tsandreview-diff.tsto treat.markdownand.asciidoc(plus existing.adoc) as docs priority 2, not source 0.rag.ts,path-matchers.ts, and review-enrichmentanalysis-context.ts(feat(enrichment): classify long-form doc extensions as docs #3329).GUIDE.markdownordocs/spec.asciidocno longer displace real source files.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlint(vianpm run test:ci)npm run typecheck(vianpm run test:ci)npm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workers(vianpm run test:ci)npm run build:mcp(vianpm run test:ci)npm run test:mcp-pack(vianpm run test:ci)npm run ui:openapi:check(vianpm run test:ci)npm run ui:lint(vianpm run test:ci)npm run ui:typecheck(vianpm run test:ci)npm run ui:build(vianpm run test:ci)npm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:cion Node 22 before push.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — backend review diff ordering only; no visible UI change.
Notes
Conflict avoidance: Touches only
src/review/review-grounding.ts,src/review/review-diff.ts, and their unit tests. Verified zero file overlap with open PRs (#3316 dart classifiers, #3304 mega, #3333/#3332 secret-scan, #3322 unsafe-any, #3331 engine, #3314 miner, #3315/#3313/#3310 selfhost, #3305 enrichment-wire, #3281 grafana, #3255 queue). Should merge cleanly after any of those land without rebase.Made with Cursor