Skip to content

feat(engine): add rankMetadataOpportunitiesAtOrAboveScore helper#3336

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-metadata-min-score-filter
Jul 5, 2026
Merged

feat(engine): add rankMetadataOpportunitiesAtOrAboveScore helper#3336
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-metadata-min-score-filter

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add rankMetadataOpportunitiesAtOrAboveScore(candidates, context, minScore) to @jsonbored/gittensory-engine: ranks metadata discovery candidates via rankMetadataOpportunities, then keeps only entries whose rankScore meets the threshold.
  • Non-finite thresholds fail closed to an empty list; finite thresholds clamp to [0, 1] before filtering.
  • Implemented in new metadata-min-score.ts (metadata-path mirror of merged rankOpportunitiesAtOrAboveScore in feat(engine): add rankOpportunitiesAtOrAboveScore helper #3334).

Why no linked issue

Small engine parity helper for the metadata fan-out path — miners can drop low-score metadata candidates without reimplementing rank ordering, miner-disabled filtering, or threshold sanitization.

Conflict avoidance

Touches only packages/gittensory-engine/src/metadata-min-score.ts (new file), packages/gittensory-engine/src/index.ts (one export line after pickTopMetadataOpportunities), and new test/unit/metadata-min-score.test.ts. Does not overlap open PRs (#3335 review-diff, #3333 secret-scan, #3322 enrichment, #3314 miner CLI, #3315/#3255 queue, #3316 signals, #3304 review holds, grafana/docs).

Codecov patch

Dedicated vitest file exercises every branch (score filter, miner-disabled skip, zero/clamped thresholds, non-finite input, empty candidates, barrel export). Local diff-cover reports 100% patch coverage on metadata-min-score.ts.

Test plan

  • npm run build --workspace @jsonbored/gittensory-engine
  • npm run build:miner
  • npx vitest run test/unit/metadata-min-score.test.ts (6 tests)
  • diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • CI validate / validate-code / codecov patch+project / orb review agent

Made with Cursor

Filter metadata discovery candidates by minimum rank score using the
shared rankMetadataOpportunities ordering and targetability rules.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from JSONbored as a code owner July 5, 2026 03:56
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (2508655) to head (f2536a3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3336   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         279      280    +1     
  Lines       30530    30534    +4     
  Branches    11118    11120    +2     
=======================================
+ Hits        28662    28666    +4     
  Misses       1211     1211           
  Partials      657      657           
Files with missing lines Coverage Δ
...ckages/gittensory-engine/src/metadata-min-score.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 04:00:51 UTC

3 files · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 5 non-blocking
  • nit: packages/gittensory-engine/src/metadata-min-score.ts:17 uses an early empty-candidates return that is harmless, but it slightly diverges from the pure delegation shape; if rankMetadataOpportunities later gains observable validation or normalization, this helper would bypass it for empty input.
  • nit: test/unit/metadata-min-score.test.ts:52 says “non-finite threshold” but only exercises NaN and positive infinity; add negative infinity too if you want the test name to fully match the contract.
  • packages/gittensory-engine/src/metadata-min-score.ts:17: Either remove the empty-input shortcut and let rankMetadataOpportunities own all input handling, or keep it with a short reason because this helper otherwise correctly delegates policy to the source ranker.
  • test/unit/metadata-min-score.test.ts:52: Add `Number.NEGATIVE_INFINITY` to the non-finite assertion set so the test documents the full fail-closed contract.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1334 registered-repo PR(s), 648 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1334 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1334 PR(s), 49 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2276, issue #2281)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2276, issue #2287)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2287, issue #2281)
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 01e96c6 into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant