feat(engine): add rankMetadataOpportunitiesAtOrAboveScore helper#3336
Conversation
Filter metadata discovery candidates by minimum rank score using the shared rankMetadataOpportunities ordering and targetability rules. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3336 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 279 280 +1
Lines 30530 30534 +4
Branches 11118 11120 +2
=======================================
+ Hits 28662 28666 +4
Misses 1211 1211
Partials 657 657
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 04:00:51 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
rankMetadataOpportunitiesAtOrAboveScore(candidates, context, minScore)to@jsonbored/gittensory-engine: ranks metadata discovery candidates viarankMetadataOpportunities, then keeps only entries whoserankScoremeets the threshold.[0, 1]before filtering.metadata-min-score.ts(metadata-path mirror of mergedrankOpportunitiesAtOrAboveScorein feat(engine): add rankOpportunitiesAtOrAboveScore helper #3334).Why no linked issue
Small engine parity helper for the metadata fan-out path — miners can drop low-score metadata candidates without reimplementing rank ordering, miner-disabled filtering, or threshold sanitization.
Conflict avoidance
Touches only
packages/gittensory-engine/src/metadata-min-score.ts(new file),packages/gittensory-engine/src/index.ts(one export line afterpickTopMetadataOpportunities), and newtest/unit/metadata-min-score.test.ts. Does not overlap open PRs (#3335 review-diff, #3333 secret-scan, #3322 enrichment, #3314 miner CLI, #3315/#3255 queue, #3316 signals, #3304 review holds, grafana/docs).Codecov patch
Dedicated vitest file exercises every branch (score filter, miner-disabled skip, zero/clamped thresholds, non-finite input, empty candidates, barrel export). Local
diff-coverreports 100% patch coverage onmetadata-min-score.ts.Test plan
npm run build --workspace @jsonbored/gittensory-enginenpm run build:minernpx vitest run test/unit/metadata-min-score.test.ts(6 tests)diff-cover coverage/lcov.info --compare-branch=main --fail-under=99→ 100%Made with Cursor