fix(signals): classify Sass source maps as generated#3453
Conversation
Sass bundlers emit .sass.map siblings; slop already treated .scss.map and .less.map as generated but missed .sass.map, so machine output was miscounted as substantive source in classifyChangedFile. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3453 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 296 296
Lines 30972 30972
Branches 11294 11294
=======================================
Hits 28803 28803
Misses 1514 1514
Partials 655 655
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 07:39:47 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
isGeneratedFileinpath-matchers.tsto treat.sass.mapas generated output, matching the existing.scss.map/.less.map/.mdx.maphandling (fix(signals): classify scss and less source maps as generated #3376, fix(signals): classify MDX source maps as generated #3446).review/visual/paths.ts; bundler source-map siblings were still miscounted as substantive source.Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesdist/theme.sass.mapas generated viaisGeneratedFileSafety
UI Evidence
N/A — backend path classifier only.
Notes
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3451 engine, #3450 enrichment provenance tests, #3443 selfhost, #3433 integrations, #3429 release workflow, #3414 review-evasion, #3314 miner, #3305 enrichment-wire, #3304 queue/gate). Merges cleanly after any of those land without rebase.Made with Cursor