fix(review): explain validation and guardrail holds

[JSONbored]

Summary

Clarifies configured validation-evidence failures and guardrail manual-hold reasons in ORB review output.

What changed

• Treat PR-body validation notes as satisfying configured manifest test expectations.
• Rename/redact the public missing-validation finding so it says changed tests or passing validation evidence are missing without leaking private config.
• Include matched guardrail paths in manual-review action reasons when available.
• Add regression coverage for the live webhook gate path plus helper/unit invariants.

Why

The previous review text could say “Maintainer test expectations unmet” even when the PR body included validation evidence, and guardrail hold reasons did not identify the touched path.

Validation

• npx vitest run test/unit/test-evidence.test.ts test/unit/focus-manifest.test.ts test/unit/public-safe-manifest-finding.test.ts test/unit/agent-actions.test.ts test/unit/gate-check-policy.test.ts test/unit/queue.test.ts
• npm run typecheck
• git diff --check

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[gittensory-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-05 05:21:20 UTC}

13 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This change correctly moves PR-body validation evidence into the manifest-policy gate and keeps predictor/live-gate parity, while also redacting the public missing-validation copy and improving guardrail hold reasons. The live webhook tests exercise the real processor path rather than fabricating only helper inputs, and the public-safe override now covers title/detail/action consistently. I do not see a reachable correctness blocker in the provided diff.

Nits — 5 non-blocking

• nit: src/signals/test-evidence.ts:54 treats any affirmative-looking clause as validation evidence even if a later adjacent clause reports failure, e.g. `Ran npm run test:ci, failed on shard 2`; consider adding a regression case if that wording is common enough to matter.
• nit: src/settings/agent-actions.ts:362 hard-codes the visible guardrail path limit as `3`; naming it would make the truncation policy clearer and keep the slice/count logic tied together.
• nit: test/unit/queue.test.ts:6266 adds three large webhook fixtures with mostly duplicated setup; consider extracting the manifest-gate repository setup and fetch stub once this grows again.
• src/signals/test-evidence.ts:54: add a targeted test for punctuation-separated failure wording around validation commands, then either document the intentional heuristic or expand the negative scan to cover the neighboring clause.
• src/settings/agent-actions.ts:362: introduce `const MAX_GUARDRAIL_REASON_PATHS = 3;` and use it for both `slice` and the remaining-count calculation.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 56 registered-repo PR(s), 46 merged, 416 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 56 PR(s), 416 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 56 PR(s), 416 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• No action.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.90%. Comparing base (1afb2ed) to head (abed057).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3304      +/-   ##
==========================================
+ Coverage   93.88%   93.90%   +0.01%     
==========================================
  Files         282      282              
  Lines       30570    30588      +18     
  Branches    11136    11143       +7     
==========================================
+ Hits        28702    28724      +22     
+ Misses       1211     1208       -3     
+ Partials      657      656       -1     

Files with missing lines	Coverage Δ
src/queue/processors.ts	93.02% <100.00%> (+0.08%)	⬆️
src/rules/predicted-gate.ts	100.00% <100.00%> (+3.12%)	⬆️
src/settings/agent-actions.ts	96.04% <100.00%> (+0.11%)	⬆️
src/signals/engine.ts	97.35% <ø> (-0.01%)	⬇️
src/signals/focus-manifest.ts	98.56% <100.00%> (+<0.01%)	⬆️
src/signals/test-evidence.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	3be6bfa	Commit Preview URL Branch Preview URL	Jul 05 2026, 02:36 AM

[gittensory-orb]

Gittensory approves — the gate is satisfied and CI is green.