Skip to content

feat(maintainers): add settings preview diagnostics#31

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
Crystora:feat/maintainer-settings-preview
May 29, 2026
Merged

feat(maintainers): add settings preview diagnostics#31
JSONbored merged 2 commits into
JSONbored:mainfrom
Crystora:feat/maintainer-settings-preview

Conversation

@Crystora

@Crystora Crystora commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #21

Adds a maintainer-facing repo settings preview and install diagnostics endpoint.

Maintainers can now dry-run what the GitHub App would do for a sample PR before enabling public output: skip, comment, label, or create a minimal check run. The preview is read-only and does not mutate GitHub.

  • Add POST /v1/repos/:owner/:repo/settings-preview.
  • Return current repo settings, installation health, missing permissions/events, remediation guidance, dry-run decision, preview label/check-run state, and sanitized public comment preview.
  • Add shared decidePublicSurface() logic and reuse it from the live webhook processor so preview behavior matches real PR handling.
  • Cover confirmed miner, non-miner quiet skip, bot author, maintainer-author skip, disabled surface, missing permissions, missing events, invalid preview input, and unknown installation health.
  • Keep check runs off by default unless explicitly enabled.
  • Update OpenAPI and changelogs.

Validation

  • npm run test:ci
  • npm run changelog:check

Safety

  • Backend-only change
  • No secrets, wallet details, user PATs, raw trust scores, or private rankings exposed
  • Public text avoids compensation-seeking or optimization-tactic language
  • OpenAPI/MCP behavior updated where needed
  • Public docs/changelogs updated where needed

@Crystora
Crystora requested a review from JSONbored as a code owner May 29, 2026 01:21
@Crystora
Crystora force-pushed the feat/maintainer-settings-preview branch from 80b9c91 to 9fcbc47 Compare May 29, 2026 01:33
@dosubot dosubot Bot added the size:XL label May 29, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #31 - feat: add repo settings preview and install diagnostics endpoint
Signal: REQUEST CHANGES

Required changes:

  • Fix changelog freshness: CI fails at changelog:check.
  • Rename PR title to conventional style, e.g. feat(maintainers): add settings preview diagnostics.
  • Remove/regenerate packages/gittensory-mcp/CHANGELOG.md drift unless this PR truly changes the npm package.
  • Add a test proving preview endpoint never mutates GitHub state.
  • Add explicit test for label-only mode with missing Issues: write.
  • Confirm settings-preview stays aligned with real webhook behavior after #29/#25 merge conflicts resolve.

@Crystora
Crystora force-pushed the feat/maintainer-settings-preview branch from 9fcbc47 to 10ff27f Compare May 29, 2026 04:31
@dosubot dosubot Bot added size:L and removed size:XL labels May 29, 2026
@Crystora
Crystora force-pushed the feat/maintainer-settings-preview branch from 10ff27f to b747f68 Compare May 29, 2026 04:32
@Crystora Crystora changed the title feat: add repo settings preview and install diagnostics endpoint feat(maintainers): add settings preview diagnostics May 29, 2026
@Crystora
Crystora requested a review from JSONbored May 29, 2026 04:35
@Crystora

Copy link
Copy Markdown
Contributor Author

@JSONbored I've updated. pls review again. thanks

@dosubot dosubot Bot added the lgtm label May 29, 2026
@JSONbored
JSONbored merged commit b0de9ea into JSONbored:main May 29, 2026
3 checks passed
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(maintainers): add repo settings preview and install diagnostics

2 participants