Skip to content

feat(github-app): add command-specific @gittensory responses#25

Merged
JSONbored merged 6 commits into
JSONbored:mainfrom
monsterdavidliu-ux:feat/18-command-specific-responses
May 29, 2026
Merged

feat(github-app): add command-specific @gittensory responses#25
JSONbored merged 6 commits into
JSONbored:mainfrom
monsterdavidliu-ux:feat/18-command-specific-responses

Conversation

@monsterdavidliu-ux

@monsterdavidliu-ux monsterdavidliu-ux commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add distinct public comment builders for @gittensory preflight, blockers, duplicate-check, and next-action instead of reusing one generic top-action section.
  • Map internal blocker codes (e.g. likely_duplicate, open_pr_pressure) to public-safe wording in maintainer-facing comments.
  • Expand unit tests for per-command titles, section content, and sanitizer regression.

Closes #18

Validation

  • npm run typecheck
  • npx vitest run test/unit/github-commands.test.ts (5/5 passed)

Safety

  • Backend-only change
  • No secrets, wallet details, user PATs, raw trust scores, or private rankings exposed
  • Public text avoids compensation-seeking or optimization-tactic language
  • OpenAPI/MCP behavior updated where needed (not applicable)
  • Public docs/changelogs updated where needed (not applicable)

@monsterdavidliu-ux
monsterdavidliu-ux force-pushed the feat/18-command-specific-responses branch from 97843aa to 90c9515 Compare May 28, 2026 23:03

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #25 - feat(github-app): add command-specific @gittensory responses
Signal: REQUEST CHANGES

Required changes:

  • Fix failing test expectation in test/unit/github-commands.test.ts.
  • Make duplicate-check output include the expected public-safe phrase, or update the test to match the intended wording.
  • Fix the duplicated sanitizer footer text: “private ranking, private context, private context”.
  • Add/keep sanitizer coverage proving no score/reward/wallet/hotkey/raw-trust/reviewability leakage.
  • Re-run validate after fixing the unit failure.

Include duplicate-check blocker labels, dedupe sanitizer footer output,
and expand public-comment leakage coverage in unit tests.
@dosubot dosubot Bot added the size:L label May 29, 2026
JSONbored and others added 2 commits May 28, 2026 23:07
Add edge-case tests for blocker label fallbacks, duplicate-risk heuristics,
preflight rerun bullets, and duplicate-check action fallback picking.
@monsterdavidliu-ux

Copy link
Copy Markdown
Contributor Author

Addressed review feedback in a1b4e03; added coverage tests in 9b3a229. Ready for re-review

@JSONbored
JSONbored merged commit 40a1172 into JSONbored:main May 29, 2026
3 checks passed
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(github-app): add command-specific @gittensory responses

2 participants