fix(selfhost): redact agent disposition metric repo labels#3946
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 56 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-07 09:02:03 UTC
🛑 Suggested Action - Manual Review
Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
CI checks failing
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
6853c01 to
a3ac40f
Compare
Three independent test/doc mismatches accumulated on main from recently merged PRs, each blocking every subsequent PR's validate-code: - queue.test.ts: 4 disposition-metric assertions predated #3946's repo label redaction and still expected the unredacted literal repo name. - predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated #3956's anti-backdating fix and asserted the old createdAt- based ordering instead of the new claim-time-only, fail-closed one. - gittensory.full.yml: missing the review.shared_config (#2046) doc section that .gittensory.yml.example already had, breaking their required byte-identical-from-marker sync.
Three independent test/doc mismatches accumulated on main from recently merged PRs, each blocking every subsequent PR's validate-code: - queue.test.ts: 4 disposition-metric assertions predated #3946's repo label redaction and still expected the unredacted literal repo name. - predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated #3956's anti-backdating fix and asserted the old createdAt- based ordering instead of the new claim-time-only, fail-closed one. - gittensory.full.yml: missing the review.shared_config (#2046) doc section that .gittensory.yml.example already had, breaking their required byte-identical-from-marker sync.
…4019) Three independent test/doc mismatches accumulated on main from recently merged PRs, each blocking every subsequent PR's validate-code: - queue.test.ts: 4 disposition-metric assertions predated #3946's repo label redaction and still expected the unredacted literal repo name. - predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated #3956's anti-backdating fix and asserted the old createdAt- based ordering instead of the new claim-time-only, fail-closed one. - gittensory.full.yml: missing the review.shared_config (#2046) doc section that .gittensory.yml.example already had, breaking their required byte-identical-from-marker sync.
Three independent test/doc mismatches accumulated on main from recently merged PRs, each blocking every subsequent PR's validate-code: - queue.test.ts: 4 disposition-metric assertions predated #3946's repo label redaction and still expected the unredacted literal repo name. - predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated #3956's anti-backdating fix and asserted the old createdAt- based ordering instead of the new claim-time-only, fail-closed one. - gittensory.full.yml: missing the review.shared_config (#2046) doc section that .gittensory.yml.example already had, breaking their required byte-identical-from-marker sync.
Motivation
Description
gittensory_agent_disposition_totalout of the self-host opt-out set and into the always-redact set insrc/selfhost/metrics.tsso itsrepolabel is never emitted verbatim.publicLabelsForMetricbehavior implicitly by updating the metric classification sets so disposition metrics are redacted even whensetSelfHostedMetricsMode(true)is called.test/unit/selfhost-metrics.test.tsto assert that disposition metrics use stable redacted repo labels in both default and self-hosted modes and to remove the previous expectation that disposition repos become visible in self-host mode.fix(selfhost): redact disposition metric repos.Testing
npx vitest run test/unit/selfhost-metrics.test.ts, which passed (36 testspassed).git diff --checkandnpm run typecheck, both succeeded locally.npm run test:coverage -- test/unit/selfhost-metrics.test.ts; tests passed but coverage report generation failed locally due toTypeError: jsTokens is not a functioninast-v8-to-istanbul(environment-specific tooling error, tests themselves passed).npm audit --audit-level=moderatecould not complete in the environment (npm audit endpoint returned HTTP 403).Codex Task