Skip to content

fix(selfhost): redact agent disposition metric repo labels #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 7, 2026
+22 −3
Merged

fix(selfhost): redact agent disposition metric repo labels #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/selfhost/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,11 @@ export function setSelfHostedMetricsMode(isSelfHosted: boolean): void {
const PRIVATE_REPO_LABEL_METRICS = new Set([
"gittensory_gate_decisions_total",
"gittensory_reviews_published_total",
]);
const ALWAYS_REDACT_REPO_LABEL_METRICS = new Set([
"gittensory_agent_disposition_total",
"gittensory_queue_backlog_by_repo",
]);
const ALWAYS_REDACT_REPO_LABEL_METRICS = new Set(["gittensory_queue_backlog_by_repo"]);
const redactedRepoLabels = new Map<string, string>();

function redactedRepoLabel(repo: string): string {
Expand Down
21 changes: 19 additions & 2 deletions test/unit/selfhost-metrics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ describe("metrics registry (#982)", () => {
setSelfHostedMetricsMode(true);
incr("gittensory_gate_decisions_total", { repo: "owner/repo", conclusion: "success" });
incr("gittensory_reviews_published_total", { repo: "owner/repo" });
incr("gittensory_agent_disposition_total", { repo: "owner/repo", action_class: "hold", blocker_class: "none", autonomy_level: "auto" });

const out = await renderMetrics();
expect(out).toContain('gittensory_gate_decisions_total{conclusion="success",repo="owner/repo"} 1');
Expand All @@ -146,7 +145,25 @@ describe("metrics registry (#982)", () => {

const out = await renderMetrics();
expect(out).not.toContain("owner/repo");
expect(out).toContain('gittensory_agent_disposition_total{action_class="hold",autonomy_level="auto",blocker_class="none"} 1');
expect(out).toContain(
'gittensory_agent_disposition_total{action_class="hold",autonomy_level="auto",blocker_class="none",repo="redacted-1"} 1',
);
});

it("keeps agent disposition repository labels redacted in self-hosted metrics mode", async () => {
setSelfHostedMetricsMode(true);
incr("gittensory_agent_disposition_total", {
repo: "private-owner/secret-repo",
action_class: "hold",
blocker_class: "manifest_blocked",
autonomy_level: "auto",
});

const out = await renderMetrics();
expect(out).toContain(
'gittensory_agent_disposition_total{action_class="hold",autonomy_level="auto",blocker_class="manifest_blocked",repo="redacted-1"} 1',
);
expect(out).not.toContain("private-owner/secret-repo");
});

it("gauges sample at scrape time", async () => {
Expand Down
Loading